Adding missing break from case statement. (issue6713130)

2 views
Skip to first unread message

fin...@chromium.org

unread,
Mar 25, 2011, 10:38:10 AM3/25/11
to da...@chromium.org, v8-...@googlegroups.com
Reviewers: danno,

Description:
Adding missing break from case statement.

Doeesn't look like a correctness issue at the moment (just a mov instruction
executed twice), but could become a correctness issue in the future.

BUG=None
TEST=None
CID=15678

Please review this at http://codereview.chromium.org/6713130/

SVN Base: http://v8.googlecode.com/svn/trunk/

Affected files:
M src/ia32/stub-cache-ia32.cc


Index: src/ia32/stub-cache-ia32.cc
===================================================================
--- src/ia32/stub-cache-ia32.cc (revision 7356)
+++ src/ia32/stub-cache-ia32.cc (working copy)
@@ -3606,6 +3606,7 @@
__ bind(&done);
}
__ mov_b(Operand(edi, ebx, times_1, 0), ecx);
+ break;
case kExternalByteArray:
case kExternalUnsignedByteArray:
__ mov_b(Operand(edi, ebx, times_1, 0), ecx);


da...@chromium.org

unread,
Mar 28, 2011, 7:05:33 AM3/28/11
to fin...@chromium.org, v8-...@googlegroups.com

Finnur Thorarinsson

unread,
Mar 28, 2011, 7:52:26 AM3/28/11
to fin...@chromium.org, da...@chromium.org, v8-...@googlegroups.com
Looks like I can't check this in (I'm outside corp).
Can you check this in for me?

On Mon, Mar 28, 2011 at 04:05, <da...@chromium.org> wrote:
LGTM

Reply all
Reply to author
Forward
0 new messages