Description:
Remove unnecessary use of raw pointers in hydrogen graph builder.
This is potentially a source of bugs, if someone inserts some code
that causes allocation.
Please review this at http://codereview.chromium.org/8818015/
SVN Base: http://v8.googlecode.com/svn/branches/bleeding_edge/
Affected files:
M src/hydrogen.cc
Index: src/hydrogen.cc
===================================================================
--- src/hydrogen.cc (revision 10179)
+++ src/hydrogen.cc (working copy)
@@ -3336,13 +3336,13 @@
int* total_size) {
if (max_depth <= 0) return false;
- FixedArrayBase* elements = boilerplate->elements();
+ Handle<FixedArrayBase> elements(boilerplate->elements());
if (elements->length() > 0 &&
elements->map() != HEAP->fixed_cow_array_map()) {
return false;
}
- FixedArray* properties = boilerplate->properties();
+ Handle<FixedArray> properties(boilerplate->properties());
if (properties->length() > 0) {
return false;
} else {
@@ -3468,7 +3468,7 @@
int length = subexprs->length();
HValue* context = environment()->LookupContext();
- FixedArray* literals = environment()->closure()->literals();
+ Handle<FixedArray> literals(environment()->closure()->literals());
Handle<Object> raw_boilerplate(literals->get(expr->literal_index()));
// For now, no boilerplate causes a deopt.