[v8] r17555 committed - Use a fixed random seed per default....

1 view
Skip to first unread message

codesite...@google.com

unread,
Nov 7, 2013, 7:01:46 AM11/7/13
to v8-...@googlegroups.com
Revision: 17555
Author: sven...@chromium.org
Date: Thu Nov 7 12:01:26 2013 UTC
Log: Use a fixed random seed per default.

To get back the old behavior, use "make randomseed=0 ...".

BUG=v8:1880,v8:2885
R=jkum...@chromium.org

Review URL: https://codereview.chromium.org/64093003
http://code.google.com/p/v8/source/detail?r=17555

Modified:
/branches/bleeding_edge/Makefile
/branches/bleeding_edge/tools/gyp/v8.gyp

=======================================
--- /branches/bleeding_edge/Makefile Fri Oct 25 05:52:11 2013 UTC
+++ /branches/bleeding_edge/Makefile Thu Nov 7 12:01:26 2013 UTC
@@ -104,6 +104,10 @@
ifeq ($(unalignedaccess), on)
GYPFLAGS += -Dv8_can_use_unaligned_accesses=true
endif
+# randomseed=12345, disable random seed via randomseed=0
+ifdef randomseed
+ GYPFLAGS += -Dv8_random_seed=$(randomseed)
+endif
# soname_version=1.2.3
ifdef soname_version
GYPFLAGS += -Dsoname_version=$(soname_version)
=======================================
--- /branches/bleeding_edge/tools/gyp/v8.gyp Tue Nov 5 13:46:11 2013 UTC
+++ /branches/bleeding_edge/tools/gyp/v8.gyp Thu Nov 7 12:01:26 2013 UTC
@@ -28,6 +28,7 @@
{
'variables': {
'v8_code': 1,
+ 'v8_random_seed%': 314159265,
},
'includes': ['../../build/toolchain.gypi', '../../build/features.gypi'],
'targets': [
@@ -156,6 +157,11 @@
'--log-snapshot-positions',
'--logfile', '<(INTERMEDIATE_DIR)/snapshot.log',
],
+ 'conditions': [
+ ['v8_random_seed!=0', {
+ 'mksnapshot_flags': ['--random-seed', '<(v8_random_seed)'],
+ }],
+ ],
},
'action': [
'<@(_inputs)',
Reply all
Reply to author
Forward
0 new messages