Move vldr in DoLoadKeyedFastDoubleElement before the hole check (issue 11363086)

6 views
Skip to first unread message

rkri...@codeaurora.org

unread,
Nov 5, 2012, 3:31:55 PM11/5/12
to da...@chromium.org, v8-...@googlegroups.com
Reviewers: danno,

Message:
Hi Danno,
I would appreciate it if you could review my change.
Thanks!

Description:
Move vldr in DoLoadKeyedFastDoubleElement before the hole check
This reschedules instructions for better VFP latency.
BUG=none
TEST=none

Please review this at https://codereview.chromium.org/11363086/

SVN Base: http://v8.googlecode.com/svn/branches/bleeding_edge/

Affected files:
M src/arm/lithium-codegen-arm.cc


Index: src/arm/lithium-codegen-arm.cc
===================================================================
--- src/arm/lithium-codegen-arm.cc (revision 12764)
+++ src/arm/lithium-codegen-arm.cc (working copy)
@@ -2993,13 +2993,12 @@
(instr->additional_index() << element_size_shift)));
}

+ __ vldr(result, elements, 0);
if (instr->hydrogen()->RequiresHoleCheck()) {
__ ldr(scratch, MemOperand(elements, sizeof(kHoleNanLower32)));
__ cmp(scratch, Operand(kHoleNanUpper32));
DeoptimizeIf(eq, instr->environment());
}
-
- __ vldr(result, elements, 0);
}




da...@chromium.org

unread,
Nov 7, 2012, 4:38:22 PM11/7/12
to rkri...@codeaurora.org, v8-...@googlegroups.com
Reply all
Reply to author
Forward
0 new messages