Relax test expectations to appease mac build. (issue 11272029)

7 views
Skip to first unread message

yan...@chromium.org

unread,
Oct 25, 2012, 8:38:05 AM10/25/12
to mstar...@chromium.org, v8-...@googlegroups.com
Reviewers: Michael Starzinger,

Description:
Relax test expectations to appease mac build.


R=mstar...@chromium.org
BUG=


Please review this at https://chromiumcodereview.appspot.com/11272029/

SVN Base: https://v8.googlecode.com/svn/branches/bleeding_edge

Affected files:
M test/mjsunit/json-recursive.js


Index: test/mjsunit/json-recursive.js
diff --git a/test/mjsunit/json-recursive.js b/test/mjsunit/json-recursive.js
index
adfd93bbcd6f693f8ffad2d758eed5009899b591..b33554ad38df3ae3b24da1f76d50bcedbdc19cf7
100644
--- a/test/mjsunit/json-recursive.js
+++ b/test/mjsunit/json-recursive.js
@@ -42,7 +42,7 @@ assertThrows(function() { rec(1, 2, 3, 4, 5, 6, 7, 8, 9,
0, 1, 2, 3, 4) },
RangeError);


-var depth1 = 2048;
+var depth1 = 1500;
var depth2 = 10000;
var deepArray = [];
for (var i = 0; i < depth1; i++) deepArray = [deepArray];


mstar...@chromium.org

unread,
Oct 25, 2012, 8:38:49 AM10/25/12
to yan...@chromium.org, v8-...@googlegroups.com
LGTM. I hope the value was chosen by fair dice roll. :)

https://codereview.chromium.org/11272029/

mvst...@chromium.org

unread,
Oct 25, 2012, 2:13:54 PM10/25/12
to yan...@chromium.org, mstar...@chromium.org, v8-...@googlegroups.com
On 2012/10/25 12:38:49, Michael Starzinger wrote:
> LGTM. I hope the value was chosen by fair dice roll. :)

Hey guys, I get this failure in a debug mac build until I lower the depth1
to
1000. Is it just me?
thx!

https://chromiumcodereview.appspot.com/11272029/
Reply all
Reply to author
Forward
0 new messages