Issue 2362 in v8: Display hidden stack values: return values and exceptions

5 views
Skip to first unread message

codesite...@google.com

unread,
Oct 13, 2012, 7:18:36 PM10/13/12
to v8-...@googlegroups.com
Status: Accepted
Owner: peter.ry...@gmail.com
Labels: Type-FeatureRequest Priority-Medium

New issue 2362 by peter.ry...@gmail.com: Display hidden stack values:
return values and exceptions
http://code.google.com/p/v8/issues/detail?id=2362

V8 debug API and protocol should expose the following stack values,
currently invisible:

- a return value, when paused below return statement
- a return value, when paused inside finally after return executed
- an exception being thrown, when paused inside finally
- when paused inside complex expression, sub-expression results such as:
* function calls,
* value conversion,
* method resolved function
* etc

See related issue from Chromium project:
http://code.google.com/p/chromium/issues/detail?id=155730

codesite...@google.com

unread,
Oct 13, 2012, 7:28:18 PM10/13/12
to v8-...@googlegroups.com

Comment #1 on issue 2362 by peter.ry...@gmail.com: Display hidden stack
values: return values and exceptions
http://code.google.com/p/v8/issues/detail?id=2362

Implementation ideas:

1. All the values are stored on stack indeed.
2. Debug stack analyzer should be able to fetch those value and return them
to user more-or-less annotated.
3. An annotation in form of <function return|method resolve|...> plus
source code position is probably optimal. A raw unannotated set of
temporary values could be returned as well, but it looks really poor.
4. Rinfo record could store these annotations. The simplest approach is to
annotate all values in each debug slot rinfo. This could nonoptimal though,
because some stack slot annotation might be repeated several times.
5. Compiler can track temporary stack slot usage by storing pointers to AST
nodes in stack – hopefully this is cheap.

codesite...@google.com

unread,
Oct 16, 2012, 3:17:43 AM10/16/12
to v8-...@googlegroups.com
Updates:
Cc: yu...@chromium.org

Comment #2 on issue 2362 by yu...@chromium.org: Display hidden stack
values: return values and exceptions
http://code.google.com/p/v8/issues/detail?id=2362

(No comment was entered for this change.)

codesite...@google.com

unread,
Oct 28, 2013, 6:22:58 AM10/28/13
to v8-...@googlegroups.com
Updates:
Status: Assigned
Owner: yan...@chromium.org
Cc: aand...@chromium.org

Comment #3 on issue 2362 by aand...@chromium.org: Display hidden stack
values: return values and exceptions
http://code.google.com/p/v8/issues/detail?id=2362

(No comment was entered for this change.)

--
You received this message because this project is configured to send all
issue notifications to this address.
You may adjust your notification preferences at:
https://code.google.com/hosting/settings

codesite...@google.com

unread,
Oct 28, 2013, 11:04:11 AM10/28/13
to v8-...@googlegroups.com

Comment #4 on issue 2362 by aand...@chromium.org: Display hidden stack
values: return values and exceptions
http://code.google.com/p/v8/issues/detail?id=2362

- a return value, when paused below return statement
this was implemented in https://codereview.chromium.org/2783002/

codesite...@google.com

unread,
Oct 28, 2013, 11:05:11 AM10/28/13
to v8-...@googlegroups.com
Issue 2362: Display hidden stack values: return values and exceptions
http://code.google.com/p/v8/issues/detail?id=2362

This issue is now blocking issue chromium:155730.
See http://code.google.com/p/chromium/issues/detail?id=155730

--
You received this message because you are listed in the owner
or CC fields of this issue, or because you starred this issue.
You may adjust your issue notification preferences at:
http://code.google.com/hosting/settings
Reply all
Reply to author
Forward
0 new messages