Removing some dead flags. (issue 9121075)

[yan...@chromium.org]

Reviewers: Kevin Millikin,

Message:
PTAL.

http://codereview.chromium.org/9121075/diff/1/src/flag-definitions.h
File src/flag-definitions.h (left):

http://codereview.chromium.org/9121075/diff/1/src/flag-definitions.h#oldcode330
src/flag-definitions.h:330: DEFINE_bool(new_snapshot, true, "use new
snapshot implementation")
FLAG_h is never used and afaik there is no old snapshot implementation
in use anymore.

http://codereview.chromium.org/9121075/diff/1/src/flag-definitions.h
File src/flag-definitions.h (right):

http://codereview.chromium.org/9121075/diff/1/src/flag-definitions.h#newcode126
src/flag-definitions.h:126: // Flags for data representation
optimizations
those are not actually "experimental" anymore.

Description:
Removing some dead flags.

BUG=
TEST=

Please review this at http://codereview.chromium.org/9121075/

SVN Base: https://v8.googlecode.com/svn/branches/bleeding_edge

Affected files:
M src/bootstrapper.cc
M src/flag-definitions.h

Index: src/bootstrapper.cc
diff --git a/src/bootstrapper.cc b/src/bootstrapper.cc
index
56302b42665a971ce0e8ec50608f759627e95656..31a771fbeb0a00f10b265ca0ddaa7227a105a361
100644
--- a/src/bootstrapper.cc
+++ b/src/bootstrapper.cc
@@ -76,22 +76,15 @@ Handle<String> Bootstrapper::NativesSourceLookup(int
index) {
Factory* factory = isolate->factory();
Heap* heap = isolate->heap();
if (heap->natives_source_cache()->get(index)->IsUndefined()) {
- if (!Snapshot::IsEnabled() || FLAG_new_snapshot) {
- // We can use external strings for the natives.
- Vector<const char> source = Natives::GetRawScriptSource(index);
- NativesExternalStringResource* resource =
- new NativesExternalStringResource(this,
- source.start(),
- source.length());
- Handle<String> source_code =
- factory->NewExternalStringFromAscii(resource);
- heap->natives_source_cache()->set(index, *source_code);
- } else {
- // Old snapshot code can't cope with external strings at all.
- Handle<String> source_code =
- factory->NewStringFromAscii(Natives::GetRawScriptSource(index));
- heap->natives_source_cache()->set(index, *source_code);
- }
+ // We can use external strings for the natives.
+ Vector<const char> source = Natives::GetRawScriptSource(index);
+ NativesExternalStringResource* resource =
+ new NativesExternalStringResource(this,
+ source.start(),
+ source.length());
+ Handle<String> source_code =
+ factory->NewExternalStringFromAscii(resource);
+ heap->natives_source_cache()->set(index, *source_code);
}
Handle<Object> cached_source(heap->natives_source_cache()->get(index));
return Handle<String>::cast(cached_source);
Index: src/flag-definitions.h
diff --git a/src/flag-definitions.h b/src/flag-definitions.h
index
07bd251673971ba85eaf08d5c2fefbd799187462..d1457397c53fc1c5d1c3f7ca83c6fce01c65183a
100644
--- a/src/flag-definitions.h
+++ b/src/flag-definitions.h
@@ -1,4 +1,4 @@
-// Copyright 2011 the V8 project authors. All rights reserved.
+// Copyright 2012 the V8 project authors. All rights reserved.
// Redistribution and use in source and binary forms, with or without
// modification, are permitted provided that the following conditions are
// met:
@@ -118,14 +118,15 @@ DEFINE_implication(harmony, harmony_proxies)
DEFINE_implication(harmony, harmony_collections)

// Flags for experimental implementation features.
-DEFINE_bool(unbox_double_arrays, true, "automatically unbox arrays of
doubles")
DEFINE_bool(smi_only_arrays, false, "tracks arrays with only smi values")
-DEFINE_bool(string_slices, true, "use string slices")
-
DEFINE_bool(clever_optimizations,
true,
"Optimize object size, Array shift, DOM strings and string +")

+// Flags for data representation optimizations
+DEFINE_bool(unbox_double_arrays, true, "automatically unbox arrays of
doubles")
+DEFINE_bool(string_slices, true, "use string slices")
+
// Flags for Crankshaft.
DEFINE_bool(crankshaft, true, "use crankshaft")
DEFINE_string(hydrogen_filter, "", "hydrogen use/trace filter")
@@ -249,7 +250,7 @@ DEFINE_bool(enable_liveedit, true, "enable liveedit
experimental feature")

// execution.cc
DEFINE_int(stack_size, kPointerSize * 128,
- "default size of stack region v8 is allowed to use (in
KkBytes)")
+ "default size of stack region v8 is allowed to use (in kBytes)")

// frames.cc
DEFINE_int(max_stack_trace_source_length, 300,
@@ -325,10 +326,6 @@ DEFINE_int(max_map_space_pages,
MapSpace::kMaxMapPageIndex - 1,
"forwarding pointers. That's actually a constant, but it's
useful "
"to control it with a flag for better testing.")

-// mksnapshot.cc
-DEFINE_bool(h, false, "print this message")
-DEFINE_bool(new_snapshot, true, "use new snapshot implementation")
-
// objects.cc
DEFINE_bool(use_verbose_printer, true, "allows verbose printing")

[kmil...@chromium.org]

This is OK with me, but let's make sure Erik agrees that --new-snapshot is
really dead.

http://codereview.chromium.org/9121075/

[erik....@gmail.com]

LGTM

http://codereview.chromium.org/9121075/