Spark error.log entries

[Sean]

Hi,
The Whiteboard and Shared Editor are awesome plugins.
However, in my Spark error logs I have entries when I close Spark
relating to both the Whiteboard and Editor starting with:

Jul 30, 2008 2:39:49 PM org.jivesoftware.spark.util.log.Log warning
WARNING: Exception on shutdown of plugin.
java.lang.NullPointerException

It seems to indicate something not unloading, probably a listener,
during when Spark closes/exist (may be in the .shudown method).
I'm running on Windows XP, Java 1.6, Spark 2.5.8, Whiteboard 0.0.4 and
Editor 1.0.1.

I tried looking through the source code briefly but can't seem to
figure out where it's going wrong. Anyone else encountering this?

Thanks.

Here's a full error log for both plugins.


Jul 30, 2008 3:42:19 PM org.jivesoftware.spark.util.log.Log warning
WARNING: Exception on shutdown of plugin.
java.lang.NullPointerException
at
org.jivesoftware.smack.XMPPConnection.removePacketListener(XMPPConnection.java:
694)
at
com.version2software.sparkplug.editor.EditorPlugin.shutdown(EditorPlugin.java:
77)
at org.jivesoftware.spark.PluginManager.shutdown(PluginManager.java:
423)
at org.jivesoftware.MainWindow.fireWindowShutdown(MainWindow.java:
234)
at org.jivesoftware.MainWindow.shutdown(MainWindow.java:263)
at
com.jivesoftware.plugin.jniwrapper.WindowsSystemTray.actionPerformed(WindowsSystemTray.java:
229)
at javax.swing.AbstractButton.fireActionPerformed(Unknown Source)
at javax.swing.AbstractButton$Handler.actionPerformed(Unknown Source)
at javax.swing.DefaultButtonModel.fireActionPerformed(Unknown Source)
at javax.swing.DefaultButtonModel.setPressed(Unknown Source)
at javax.swing.AbstractButton.doClick(Unknown Source)
at javax.swing.plaf.basic.BasicMenuItemUI.doClick(Unknown Source)
at javax.swing.plaf.basic.BasicMenuItemUI
$Handler.mouseReleased(Unknown Source)
at java.awt.Component.processMouseEvent(Unknown Source)
at javax.swing.JComponent.processMouseEvent(Unknown Source)
at java.awt.Component.processEvent(Unknown Source)
at java.awt.Container.processEvent(Unknown Source)
at java.awt.Component.dispatchEventImpl(Unknown Source)
at java.awt.Container.dispatchEventImpl(Unknown Source)
at java.awt.Component.dispatchEvent(Unknown Source)
at java.awt.LightweightDispatcher.retargetMouseEvent(Unknown Source)
at java.awt.LightweightDispatcher.processMouseEvent(Unknown Source)
at java.awt.LightweightDispatcher.dispatchEvent(Unknown Source)
at java.awt.Container.dispatchEventImpl(Unknown Source)
at java.awt.Window.dispatchEventImpl(Unknown Source)
at java.awt.Component.dispatchEvent(Unknown Source)
at java.awt.EventQueue.dispatchEvent(Unknown Source)
at java.awt.EventDispatchThread.pumpOneEventForFilters(Unknown
Source)
at java.awt.EventDispatchThread.pumpEventsForFilter(Unknown Source)
at java.awt.EventDispatchThread.pumpEventsForHierarchy(Unknown
Source)
at java.awt.EventDispatchThread.pumpEvents(Unknown Source)
at java.awt.EventDispatchThread.pumpEvents(Unknown Source)
at java.awt.EventDispatchThread.run(Unknown Source)
Jul 30, 2008 3:42:19 PM org.jivesoftware.spark.util.log.Log warning
WARNING: Exception on shutdown of plugin.
java.lang.NullPointerException
at
org.jivesoftware.smack.XMPPConnection.removePacketListener(XMPPConnection.java:
694)
at
com.version2software.sparkplug.whiteboard.WhiteboardPlugin.shutdown(WhiteboardPlugin.java:
113)
at org.jivesoftware.spark.PluginManager.shutdown(PluginManager.java:
423)
at org.jivesoftware.MainWindow.fireWindowShutdown(MainWindow.java:
234)
at org.jivesoftware.MainWindow.shutdown(MainWindow.java:263)
at
com.jivesoftware.plugin.jniwrapper.WindowsSystemTray.actionPerformed(WindowsSystemTray.java:
229)
at javax.swing.AbstractButton.fireActionPerformed(Unknown Source)
at javax.swing.AbstractButton$Handler.actionPerformed(Unknown Source)
at javax.swing.DefaultButtonModel.fireActionPerformed(Unknown Source)
at javax.swing.DefaultButtonModel.setPressed(Unknown Source)
at javax.swing.AbstractButton.doClick(Unknown Source)
at javax.swing.plaf.basic.BasicMenuItemUI.doClick(Unknown Source)
at javax.swing.plaf.basic.BasicMenuItemUI
$Handler.mouseReleased(Unknown Source)
at java.awt.Component.processMouseEvent(Unknown Source)
at javax.swing.JComponent.processMouseEvent(Unknown Source)
at java.awt.Component.processEvent(Unknown Source)
at java.awt.Container.processEvent(Unknown Source)
at java.awt.Component.dispatchEventImpl(Unknown Source)
at java.awt.Container.dispatchEventImpl(Unknown Source)
at java.awt.Component.dispatchEvent(Unknown Source)
at java.awt.LightweightDispatcher.retargetMouseEvent(Unknown Source)
at java.awt.LightweightDispatcher.processMouseEvent(Unknown Source)
at java.awt.LightweightDispatcher.dispatchEvent(Unknown Source)
at java.awt.Container.dispatchEventImpl(Unknown Source)
at java.awt.Window.dispatchEventImpl(Unknown Source)
at java.awt.Component.dispatchEvent(Unknown Source)
at java.awt.EventQueue.dispatchEvent(Unknown Source)
at java.awt.EventDispatchThread.pumpOneEventForFilters(Unknown
Source)
at java.awt.EventDispatchThread.pumpEventsForFilter(Unknown Source)
at java.awt.EventDispatchThread.pumpEventsForHierarchy(Unknown
Source)
at java.awt.EventDispatchThread.pumpEvents(Unknown Source)
at java.awt.EventDispatchThread.pumpEvents(Unknown Source)
at java.awt.EventDispatchThread.run(Unknown Source)

[larry sherrill]

Hi Sean,

We haven't seen those errors but we take a look at it in the next few
days and see if we can reproduce it. Let us know if you find
something.

Thanks, Larry

[Sean]

Hi Larry,
So I did a work around by doing the following in the shutdown
functions and recompiling.


in EditorPlugin.java I commented out in the following:


public void shutdown() {

/* SparkManager.getConnection().removePacketListener(listener);
*/
ProviderManager providerManager = ProviderManager.getInstance();
providerManager.removeExtensionProvider(Cursor.ELEMENT_NAME,
EditorConstants.NAMESPACE);
providerManager.removeExtensionProvider(Insert.ELEMENT_NAME,
EditorConstants.NAMESPACE);
providerManager.removeExtensionProvider(Remove.ELEMENT_NAME,
EditorConstants.NAMESPACE);
providerManager.removeExtensionProvider(Update.ELEMENT_NAME,
EditorConstants.NAMESPACE);
}

and in WhiteboardPlugin.java I commented out:

public void shutdown() {


manager.removeExtensionProvider(SVGConstants.ELEMENT_NAME,
SVGConstants.NAMESPACE);
manager.removeIQProvider(WhiteboardInvitation.ELEMENT_NAME,
SVGConstants.NAMESPACE);
manager.removeIQProvider(WhiteboardNotification.ELEMENT_NAME,
SVGConstants.NAMESPACE);

/* connection.removePacketListener(svgPacketListener);
connection.removePacketListener(invitationListener);
connection.removePacketListener(notificationListener);


svgPacketListener = null;
invitationListener = null;
notificationListener = null;

whiteboardMap = null;
workspace = null;
manager = null;
*/ }



This isn't very good as the listeners aren't being removed gracefully
but at least I'm not getting the javanullexception errors in my Spark
log files. Any idea why they might be null or something related is
null when closing Spark?

Thanks for your help.

Cheers,
Sean

> >         at java.awt.EventDispatchThread.run(Unknown Source)- Hide quoted text -
>
> - Show quoted text -

[larry sherrill]

Hi Sean,

Thanks for narrowing that down. Something must have changed somewhere.
We will investigate it and see if we need to change something in our
shutdown code.

Thanks, Larry