Re: Change the JIT to produce mostly register-machine based code. (issue1905048)
e...@4geeks.de
PTAL
http://codereview.appspot.com/1905048/diff/7001/8012
File JIT/llvm_fbuilder.cc (right):
http://codereview.appspot.com/1905048/diff/7001/8012#newcode32
JIT/llvm_fbuilder.cc:32: #include <iostream>
On 2010/08/03 17:43:42, Reid Kleckner wrote:
> I don't think this is needed.
Done.
http://codereview.appspot.com/1905048/diff/7001/8012#newcode66
JIT/llvm_fbuilder.cc:66: static int
On 2010/08/03 17:43:42, Reid Kleckner wrote:
> Comment what this is doing.
Done.
http://codereview.appspot.com/1905048/diff/7001/8012#newcode71
JIT/llvm_fbuilder.cc:71: if (stack_info[iter.CurIndex()] >= 0) {
On 2010/08/03 17:43:42, Reid Kleckner wrote:
> Comment that this is checking that if the stack level for this opcode
has been
> initialized, then we check that we got the same stack level from both
control
> flow paths and then cut off the recursion.
Done.
http://codereview.appspot.com/1905048/diff/7001/8012#newcode80
JIT/llvm_fbuilder.cc:80: stack_level = 1000;
On 2010/08/04 02:26:52, James Abbatiello wrote:
> What's this doing? Could it use a comment?
Done.
http://codereview.appspot.com/1905048/diff/7001/8012#newcode1254
JIT/llvm_fbuilder.cc:1254: this->builder_.CreateStore(new_stack_pointer,
this->stack_pointer_addr_);
On 2010/08/03 17:43:42, Reid Kleckner wrote:
> 80
Done.
http://codereview.appspot.com/1905048/diff/7001/8002
File JIT/llvm_fbuilder.h (right):
http://codereview.appspot.com/1905048/diff/7001/8002#newcode151
JIT/llvm_fbuilder.h:151: /// This method reads on the direction of the
growing stack.
On 2010/08/03 17:43:42, Reid Kleckner wrote:
> It's important that this line is clear. I'd write this as:
> "Increasing argument offsets read in the direction of stack growth."
Done.
http://codereview.appspot.com/1905048/diff/7001/8002#newcode154
JIT/llvm_fbuilder.h:154: /// May only be called once per result per
IR-codepath.
On 2010/08/03 17:43:42, Reid Kleckner wrote:
> s/May/Must/
Done.
reid.k...@gmail.com
SetOpcodeArgsWithGuard.