My first contribution to Umple: the patch for issue 279

5 views
Skip to first unread message

Aliaa

unread,
Jun 25, 2012, 2:58:28 PM6/25/12
to Umple-Dev
Hi,

I created a patch for solving (issue-297) : "allowing Guard and Action
before a statemachine transition"

Check the following link:
http://code.google.com/p/umple/issues/detail?can=2&start=0&num=100&q=297&colspec=ID%20Type%20Component%20Diffic%20Status%20Priority%20Owner%20Summary&groupby=&sort=&id=297

Please, review it and let me know if I there is any mistak in solving
this issue..

Timothy Lethbridge

unread,
Jun 25, 2012, 4:13:14 PM6/25/12
to Umple-Dev
I just broke the build committing Aliaa's patch, which seemed to work OK
on my machine ... will investigate.
> --
> You received this message because you are subscribed to the Google Groups "Umple-Dev" group.
> To post to this group, send an email to umpl...@googlegroups.com.
> To unsubscribe from this group, send email to umple-dev+...@googlegroups.com.
> For more options, visit this group at http://groups.google.com/group/umple-dev?hl=en-GB.
>
>


Timothy C. Lethbridge, PhD, P.Eng., I.S.P., CSDP
Professor of Software Engineering and Computer Science
/ Professeur Titulaire de g�nie logiciel et d'informatique
Facult� de genie / Faculty of Engineering
University of Ottawa / Universit� d'Ottawa
Tel: 613-562-5800x6685 Fax: 613-562-5664 Mobile: 613-252-1850
http://www.eecs.uottawa.ca/~tcl

Timothy Lethbridge

unread,
Jun 25, 2012, 4:36:39 PM6/25/12
to Umple-Dev, Gregor v. Bochmann
Congratulations Aliaa on your first successful patch that is active as of
r1878.

If you try the latest build (i.e. on UmpleOnline) it is now more flexible
about the transition notation.

The build-break I encountered on applying the patch related to unix vs.
Windows line-end convention, and an error I made dealing with that on my
machine. I resolved it.

One quick point: When creating a patch, it is important to create it while
in directory of the 'trunk' of umple (the patch was created when in the
umple-dev subhierarchy). See
http://code.google.com/p/umple/wiki/CreatingAndApplyingPatches?ts=1340654045&updated=CreatingAndApplyingPatches

- Tim
Reply all
Reply to author
Forward
0 new messages