Issue 60 in uby: GPL licence check fails on Maven deployment

8 views
Skip to first unread message

u...@googlecode.com

unread,
Oct 8, 2013, 10:51:40 AM10/8/13
to uby-dev...@googlegroups.com
Status: Accepted
Owner: tristan...@nothingisreal.com
CC: yevgen.c...@gmail.com
Labels: Type-Defect Priority-Medium

New issue 60 by tristan...@nothingisreal.com: GPL licence check fails
on Maven deployment
http://code.google.com/p/uby/issues/detail?id=60

We use the License Maven Plugin by mycila to check licence headers in the
GPL modules. It works perfectly when doing a build, but not when doing a
deploy. It complains about missing or invalid licence headers in the
modules' pom.xml files.

Possibly this is because when Maven prepares a release, it updates the POM
to bump the version number, remove snapshot dependencies, etc. When it does
this perhaps it is changing the licence header in some subtle way which
nonetheless causes it not to match the version in
the .activate_license-check file. If this is the case, then either we
haven't correctly configured the plugin, or else there's a bug in the
plugin. Further investigation is required.

In the meantime we have temporarily worked around the problem by adding
pom.xml to the plugin's exclusion list.

--
You received this message because this project is configured to send all
issue notifications to this address.
You may adjust your notification preferences at:
https://code.google.com/hosting/settings

u...@googlecode.com

unread,
Oct 14, 2013, 5:54:08 AM10/14/13
to uby-dev...@googlegroups.com

Comment #1 on issue 60 by tristan...@nothingisreal.com: GPL licence
check fails on Maven deployment
http://code.google.com/p/uby/issues/detail?id=60

I have confirmed my suspicion: When the "maven release:prepare" modifies
pom.xml files (e.g., to update snapshot dependencies), it subtly alters the
licence header. In particular, the line

along with this program. If not, see <http://www.gnu.org/licenses/>.

gets changed to

along with this program. If not, see <http://www.gnu.org/licenses />.

I think this is a bug in Maven. It shouldn't be adjusting formatting of
the XML comments (and especially not in a URL where whitespace is
significant). I will report the issue upstream. In the meantime, we need
to continue to exclude XML files from the GPL licence check.

u...@googlecode.com

unread,
Oct 14, 2013, 5:58:08 AM10/14/13
to uby-dev...@googlegroups.com

Comment #2 on issue 60 by richard.eckart: GPL licence check fails on Maven
deployment
http://code.google.com/p/uby/issues/detail?id=60

If this is in an XML file, then it may be interpreted as a self-closing
element with the name "http://www.gnu.org/licenses". In that case, the
transformation is perfectly valid.

u...@googlecode.com

unread,
Oct 14, 2013, 6:21:04 AM10/14/13
to uby-dev...@googlegroups.com

Comment #3 on issue 60 by tristan...@nothingisreal.com: GPL licence
check fails on Maven deployment
http://code.google.com/p/uby/issues/detail?id=60

Issue reported for Maven: http://jira.codehaus.org/browse/MNG-5524

u...@googlecode.com

unread,
Oct 14, 2013, 6:23:35 AM10/14/13
to uby-dev...@googlegroups.com

Comment #4 on issue 60 by richard.eckart: GPL licence check fails on Maven
deployment
http://code.google.com/p/uby/issues/detail?id=60

Sorry, I missed the part about the comment. In a comment, the < should
loose its special function, so in fact no reformatting should happen.

u...@googlecode.com

unread,
Oct 14, 2013, 6:25:16 AM10/14/13
to uby-dev...@googlegroups.com

Comment #5 on issue 60 by tristan...@nothingisreal.com: GPL licence
check fails on Maven deployment
http://code.google.com/p/uby/issues/detail?id=60

Correct. Just to be sure I ran the POM through the W3C's XML validator and
there are no syntax errors.

u...@googlecode.com

unread,
Oct 14, 2013, 6:29:36 AM10/14/13
to uby-dev...@googlegroups.com

Comment #6 on issue 60 by richard.eckart: GPL licence check fails on Maven
deployment
http://code.google.com/p/uby/issues/detail?id=60

You could try adding the maven release plugin to your build configuration
(e.g. in the plugin management section) in the POM and adding dependencies
to recent Xalan and Xerces versions explicitly to this plugin (plugins can
have nested dependencies).

u...@googlecode.com

unread,
Apr 10, 2015, 11:14:35 AM4/10/15
to uby-dev...@googlegroups.com
Updates:
Labels: -Milestone-0.7.0

Comment #9 on issue 60 by chmeyer.de: GPL licence check fails on Maven
deployment
https://code.google.com/p/uby/issues/detail?id=60

I have tried adding xerces and xalan, but it did not work (I used a test
project to try it out). Here's what I added to the GPL-licensed POM:


<plugins>
<plugin>
<groupId>org.apache.maven.plugins</groupId>
<artifactId>maven-release-plugin</artifactId>
<dependencies>
<dependency>
<groupId>xalan</groupId>
<artifactId>xalan</artifactId>
<version>2.7.2</version>
</dependency>
<dependency>
<groupId>xerces</groupId>
<artifactId>xercesImpl</artifactId>
<version>2.11.0</version>
</dependency>
</dependencies>
</plugin>
</plugins>
</build>

Leaving this to future releases.
Reply all
Reply to author
Forward
0 new messages