pid-file location

[ronnie sahlberg]

Currently the pid file is hardcoded to reside in /tmp/ublksrv which could be an issue if the tmp-cleaner removes them for long running targets.

I think they should either reside in /run or /var/run.

If there is consensus I will look into doing this change.

[Ming Lei]

On Thu, Feb 20, 2025 at 06:15:47AM +1000, ronnie sahlberg wrote:
> Currently the pid file is hardcoded to reside in /tmp/ublksrv which could
> be an issue if the tmp-cleaner removes them for long running targets.

Yeah, it looks one issue.

>
> I think they should either reside in /run or /var/run.

Both /run and /var/run are over /tmpfs, but it is fine for ublk's case
since the device can't live across reboot/power off.

Either of the two are fine for me, maybe /run is better since in modern
distributions, /var/run is a symbol link to /run.

> If there is consensus I will look into doing this change.

That is great!


Thanks,
Ming