default language preference for "translate" command.

[pvncad]

Hi,

I have added support for using preference for default language rather
than hard coding it to English.
(http://labs.toolness.com/trac/ticket/225)

I have posted the patch in trac ticket. Could someone take a look at
it ?

Thanks
pvncad

[Abimanyu Raja]

Hey,

Thanks for the patch. See my comment: http://labs.toolness.com/trac/ticket/225#comment:6.

- Abi

2009/1/4 pvncad <pvn...@gmail.com>

[pvncad]

Thanks Abi.

I am really excited about this as this is my first contribution to
ubiquity source. I know it is
very small change but still I am happy that I got a start.

Regarding your comment in the trac, I thought of using
general.useragent.locale and also extensions.ubiquity.language pref,
but thought having a separate pref will give finer control to user.

-pvncad

[Aza]

Hey Pvncad,

Thanks for getting involved! Just wanted to say welcome to the community :)

-- aza | ɐzɐ --

[Abimanyu Raja]

Hi pvncad,

I used both prefs. So, if you have extensions.ubiquity.language, that language will be your default. But for most ppl who don't have it set, general.useragent.locale's value will be used as the default.

Thanks for the patch and welcome to the community!

- Abi

2009/1/5 pvncad <pvn...@gmail.com>

[pvncad]

I think, using "general.useragent.locale" might break for some people.
As locale code and language code defined for translate
can be different. One such locale code is en-US.

Anyway, I will try to test with your changes and update my
observations.

-pvncad

[pvncad]

Yes. current changes are broken in my firefox which has
"general.useragent.locale" set
to "en-US" by default.

- pvncad