Bug in the mongodb datastore stub

[Joaquin Cuenca Abela]

Hi,

AE native datastore accepts strings (encoded as ascii) and unicode as
key names in entities, but if you try to insert an object with an
unicode key using the mongodb backend (I didn't tried the other
backends) it fails.

The error comes from lines 349 - 350 in mongodb/datastore_mongo_db.py,
as it adds to the response pb the id received from saving the document
in mongodb:

id = self.__db[collection].save(document)
put_response.key_list().append(self.__key_for_id(id)._ToPb())

I guess it assumes the id is the id that we constructed previously in
the document. Mongodb always answers using utf-8, so the answer needs
to be converted to unicode

id = self.__db[collection].save(document).decode("utf-8")
put_response.key_list().append(self.__key_for_id(id)._ToPb())

another solution will be (I guess) to reuse the _id we put in the document.
I added a unit test for this case:

def testGetPutUnicode(self):
"""Sets and Gets models with unicode key names."""

class Author(db.Model):
name = db.StringProperty()

Author(name=u'Jes\u00fas Cebri\u00e1n',
key_name=u'jes\u00fascebri\u00e1n').put()

a = Author.get_by_key_name(u'jes\u00fascebri\u00e1n')

self.assertEqual('Author', a.kind())
self.assertEqual(u'Jes\u00fas Cebri\u00e1n', a.name)

a.delete()
del a

I'm quite new to mercurial, Tobias please can you instruct meon how do
you prefer to receive patches?

Thanks!

--
Joaquin Cuenca Abela

[Tobias]

Hi Joaquin,

Many thanks for providing this patch! I've already applied it.

http://code.google.com/p/typhoonae/source/detail?r=2010091590b43ab7014f904401c5f21f3d663247

The Datastore MySQL stub does not have this issue. I've applied your
test case there, too.

It's perfectly fine to submit a patch this way. Usually, I add an
issue as well. This helps to keep track about changes for the release
notes. However, I'm really glad that you help.

- Tobias

On Oct 5, 7:23 pm, Joaquin Cuenca Abela <joaq...@cuencaabela.com>
wrote: