Guava dependency update

252 views
Skip to first unread message

Miroslav Genov

unread,
Jun 21, 2012, 11:33:43 AM6/21/12
to twig-p...@googlegroups.com
Hello,

Are there are any plans version of Guava to be updated to 11 or 12 anytime soon ?

Regards,
  Miroslav

John Patterson

unread,
Jun 22, 2012, 12:43:00 AM6/22/12
to twig-p...@googlegroups.com
The problem is that quite a lot has been deprecated (e.g. MapBuilder stuff moved to CacheBuilder) forcing a number of changes. It changes so fast!

I guess the best thing to do is go with 12 for the 2.0 release.

I will release 2.0 next week as I have a little more time. Docs might take a bit longer but hopefully you guys can help there!

Miroslav Genov

unread,
Jun 22, 2012, 4:19:34 AM6/22/12
to twig-p...@googlegroups.com
Hello,

I found that twig has only 2,3 dependencies to MapBuilder (in the latest version) which is not that much. I switched pom to use version 12 and made a small fix that replaces MapBuilder with CacheBuilder and when put/get is required I use cache.asMap().get(key) which made all tests to pass. It's not an elegant way for this change, but more stuff need to be changed in case you want CacheLoader class to be used instead of asMap().put() method.

If you want I can submit all of my changes as patch for review which contains fixes for: 
  • returnParents method
  • Version 12 of Guava
  • Fix for retrieving of Set<?> of entities 

Georgi Georgiev

unread,
Apr 24, 2013, 7:54:40 AM4/24/13
to twig-p...@googlegroups.com
Hello,

Is there any progress on the topic?

Georgi Georgiev

unread,
Jun 5, 2013, 8:18:08 AM6/5/13
to twig-p...@googlegroups.com

Hi John,


Is there a reason to delay update of guava?


I integrated Guava 14.0 with twig. I’m attaching a patch which contains a simple change that replaces MapMaker with the CacheBuilder.


I would appreciate if you look at it.
integrate_guava_14_0.patch

Nathan Toone

unread,
Jul 22, 2013, 10:49:13 AM7/22/13
to twig-p...@googlegroups.com
I can also validate that this patch works for me.  Hopefully it can be included soon(ish)

-Nathan
Reply all
Reply to author
Forward
0 new messages