Interactive mode scan asking which file to keep

[iammrfrank]

When the user is in interactive (clicks the scan button or checks a single show) and more than 1 file matches something in the directory, they're always getting a prompt to choose which one to keep. It's ignoring the setting "Choose between episodes in library when multiple match" and "update episodes when higher-quality ones found in search folders".

I'm not sure if the github is up to date, because it shows version 3.0 or something, but here's what I think is happening. 

No matter what the user's settings, the user is being prompted to choose which file. This seems to be because in ScanActivity\CleanDownloadDirectory.cs 
case FileHelper.VideoComparison.similar doesn't have an if statement after the else statement. 

Something like:
if (unattended || (!TVSettings.Instance.ReplaceWithBetterQuality && !TVSettings.Instance.ChooseWhenMultipleEpisodesMatch))

[Steven K]

I took a look at the source code and looks like you're on the right track. The similar and cantTell cases do already check whether the scan is running unattended, so that part works fine. The problem is what happens when it's not unattended in your interactive mode as just it skips straight to asking the user, completely ignoring both the "Choose when multiple match" and "Replace with better quality" settings. The secondFileBetter case handles those settings correctly, but similar/cantTell just doesn't. I think the condition would just need to go inside the existing else block wrapping the AskUserAboutFileReplacement call. Also worth noting, ReviewFile has two overloads, one for shows and one for movies. They both look to have the same problem.

[iammrfrank]

Yup. That's exactly what I was seeing. I think just adding the settings checks to the if unattended statement would be fine. My initial idea was alongside the else statement, but I think as I looked at it, I think just updating the if statement would be better. Would avoid even going down that logic and save cycles. I'm not sure if you're a dev, should be an easy fix if you can push to the git and someone can release another version. 

I downloaded the repo, corrected the tvshow and movie sections and then compiled and it worked for me. 

[iammrfrank]

I went ahead and cloned the repo, fixed the problem and then compiled and deployed it, only to find out the version on github takes MUCH longer to scan... 

I found the issue was the MediaMetaData identifier function, so I commented that out and tried again and now it's back to being fast(er) and doesn't have the interactive scan issues. 

I'm not sure if there's any settings related to the mediametadata, but I couldn't find any....

DownloadIdentifiersController seems to call it from MediaMetaData.cs, which doesn't have any settings-based if statements, so I assume I'd have to add a setting in the interface and an if statement to check for it.. which isn't worth it for me personally, since I doubt I'll ever use it... 

[Steven K]

It’s using TagLib to read and write metadata tags directly into your media files on every scan so that definitely explains the slowdown. With no setting gate, commenting it out seems like a good call. Kudos.

[Tom Snyder]

The bottom line is that with each day TVRename 5.08 gets more outdated. What it comes down to is that we need a new developer to work on TVRename since Mark no longer wishes to work on it. Any volunteers? Perhaps if Mark is reading this, he could be kind enough to upload the very latest source to GitHub that he worked on. I have to give extreme kudos to Mark for hanging in there for so long and advancing the level of coding it is today from a very simple renaming program.

[iammrfrank]

1, 2, 3 not me.

I haven't used any C in years or else I would offer. Any more than commenting out, some basic if statements and reading code, I'm certainly not qualified for a project as large as this one. I'd probably introduce more bugs than fixes. 

[Tom Snyder]

I hear you. I'd be lucky to be able to write a "HELLO WORLD" DOS batch script without screwing it up. My education in PDP-11 BASIC, FORTRAN, IBM360 COBOL, and assembler language doesn't translate well to today's coding methods. Thank you anyway for your response.