CrudRestController and @before_validate
Moritz Schlarb
Alessandro Molina
I tested it on the fly and it seems to correctly work as expected.
class MyGroupRestController(EasyCrudRestController):
model = model.Group
def before_put(self, *args, **kw):
print args, kw
def __init__(self, *args, **kw):
super(MyGroupRestController, self).__init__(*args, **kw)
before_validate(self.before_put)(self.put)
There are other ways to register the hook, but they should all work correctly.
> --
> You received this message because you are subscribed to the Google Groups
> "TurboGears" group.
> To view this discussion on the web visit
> https://groups.google.com/d/msg/turbogears/-/qTqkd_d9t0gJ.
> To post to this group, send email to turbo...@googlegroups.com.
> To unsubscribe from this group, send email to
> turbogears+...@googlegroups.com.
> For more options, visit this group at
> http://groups.google.com/group/turbogears?hl=en.
Moritz Schlarb
Moritz Schlarb
Alessandro Molina
I forgot that Pylons based versions of TG reallocate the controller on
each request, as you are hooking the before_validate inside the
__init__ this has the side effect of registering the validate hook
each time you get a request.
Change it to something like:
class MyGroupRestController(EasyCrudRestController):
model = model.Group
def before_put(self, *args, **kw):
print args, kw
before_validate(MyGroupRestController.before_put)(MyGroupRestController.put)
This is one of the things that are going to change on in 2.3+ which
allocates the controllers only on application startup, in the mean
time you must avoid doing anything that changes the controller class
inside the init itself.
>>> > turbogears+...@googlegroups.com.
>>> > For more options, visit this group at
>>> > http://groups.google.com/group/turbogears?hl=en.
>
> --
> You received this message because you are subscribed to the Google Groups
> "TurboGears" group.
> To view this discussion on the web visit
> https://groups.google.com/d/msg/turbogears/-/LUazTYzarrcJ.
>
> To post to this group, send email to turbo...@googlegroups.com.
> To unsubscribe from this group, send email to
> turbogears+...@googlegroups.com.
Alessandro Molina
a static/class method as you are registering it without self.
Moritz Schlarb
>>>> > For more options, visit this group at
>>>> > http://groups.google.com/group/turbogears?hl=en.
>>
>> --
>> You received this message because you are subscribed to the Google Groups
>> "TurboGears" group.
>> To view this discussion on the web visit
>> https://groups.google.com/d/msg/turbogears/-/LUazTYzarrcJ.
>>
>> To post to this group, send email to turbo...@googlegroups.com.
>> To unsubscribe from this group, send email to
Alessandro Molina
controller using tg.dispatched_controller()
This way you will be able to access the controller instance and
retrieve the property you need even from the class method.
About the behavior of the before_validate parameters, that is actually
the right one.
I used *args and **kw just because I'm lazy and didn't want to specify
the right parameters.
The expected before_validate hook signature is:
def before_validate_hook(remainder, params):
if you use *args and **kw you simply get the remainder and the params
inside the args argument :D
>> >>>> > turbogears+...@googlegroups.com.
>> >>>> > For more options, visit this group at
>> >>>> > http://groups.google.com/group/turbogears?hl=en.
>> >>
>> >> --
>> >> You received this message because you are subscribed to the Google
>> >> Groups
>> >> "TurboGears" group.
>> >> To view this discussion on the web visit
>> >> https://groups.google.com/d/msg/turbogears/-/LUazTYzarrcJ.
>> >>
>> >> To post to this group, send email to turbo...@googlegroups.com.
>> >> To unsubscribe from this group, send email to
>> >> turbogears+...@googlegroups.com.
>> >> For more options, visit this group at
>> >> http://groups.google.com/group/turbogears?hl=en.
>
> --
> You received this message because you are subscribed to the Google Groups
> "TurboGears" group.
> To view this discussion on the web visit
> https://groups.google.com/d/msg/turbogears/-/Dgo6nOyTDfQJ.
>
> To post to this group, send email to turbo...@googlegroups.com.
> To unsubscribe from this group, send email to
> turbogears+...@googlegroups.com.
Moritz Schlarb
>> >>>> > turbogears+unsubscribe@googlegroups.com.
>> >>>> > For more options, visit this group at
>> >>>> > http://groups.google.com/group/turbogears?hl=en.
>> >>
>> >> --
>> >> You received this message because you are subscribed to the Google
>> >> Groups
>> >> "TurboGears" group.
>> >> To view this discussion on the web visit
>> >> https://groups.google.com/d/msg/turbogears/-/LUazTYzarrcJ.
>> >>
>> >> To post to this group, send email to turbo...@googlegroups.com.
>> >> To unsubscribe from this group, send email to
>> >> For more options, visit this group at
>> >> http://groups.google.com/group/turbogears?hl=en.
>
> --
> You received this message because you are subscribed to the Google Groups
> "TurboGears" group.
> To view this discussion on the web visit
> https://groups.google.com/d/msg/turbogears/-/Dgo6nOyTDfQJ.
>
> To post to this group, send email to turbo...@googlegroups.com.
> To unsubscribe from this group, send email to
Alessandro Molina
> Alessandro,
>
> I just ran into an issue with tgext.crud, since it generates pager links
> based on self._mount_point().
> They look like they would have been generated from the last statically
> dispatched controller, so there are some parts missing.
>
> In tgext/crud/controller.py, line 144, you could probably replace
> tg.dispatched_controller().mount_point
> with
> request.controller_state.controller.mount_point
>
so it won't probably solve the issue.
If the issue is caused by the fact that you need to allocate the
controllers with some options you can use cached_property to make it
behave as it was statically mounted. Take a look at
https://bitbucket.org/_amol_/tgapp-photos/src/81288e064f75/photos/controllers/root.py
to see what I mean.
If you really need to serve the controllers from _lookup you must
override _mount_point to use request.path_info
Something like request.path_info[len(tg.dispatched_controller().mount_point):].split('/')[0]
might be the way to go, but I don't have any ready made snippet for
something like that as I always served crud rest controllers from
statically mounted places or cached properties.
Moritz Schlarb
Alessandro Molina
> I have now just set the mount_point to . and it seems to work, the pager
> links are correct now and I haven't noticed any other breakage...
>
> @cached_property
> def mount_point(self):
> return '.'
>
Switching crud itself to use a relative mount point when not
statically mounted would probably make sense.
I'll just have to check why it has been switched to full path since it
was already served using relative urls and I remember that relative
paths were the source of some issues.