1.x ticket review
Christopher Arndt
here is a review of some misc trac tickets concerning milestone
1.0.x-bugfix, 1.1 or 1.5 that have open issues and where we need
feedback. This is just an arbitrary selection of tickets that caught my
attention, there are a lot more open issues for these milestones. I will
try to continue this review tomorrow.
#1498 (http://trac.turbogears.org/ticket/1498):
This already a year old but seems like a important enough fix
to put in 1.1. Any volunteers to review the code? Writing a test
is difficult because the change only concerns JS code.
#1500 (http://trac.turbogears.org/ticket/1500):
One of my old favorites. I have updated the "Upgrades" page with
info for upgrading from 1.0.4 to 1.0.5 to 1.0.6. Please check if
anything is missing or incorrect.
We need to use the 1.1 beta phase to provide upgrade instructions
for updating apps from 1.0 to 1.1. I created a skeleton page for
this purpose here:
http://docs.turbogears.org/1.1/RoughDocs/Upgrade
Volunteers to fill this page are very welcome!
There still is no info on the 1.0 Upgrade page about updating very
old TG apps from 0.9.x to 1.0.x. I didn't use TurboGears seriously
until about 1.0b4 so I don't have any old apps to test this with. If
anybody has updated such an app to TG 1.0 and can help us to fill
this void that would be very welcome too.
#1796 (http://trac.turbogears.org/ticket/1796):
droggisch re-opened this because it was not fixed in 1.0.5 but it
was already fixed in the HEAD of the branch. Please re-test and
close the bug.
#1875 (http://trac.turbogears.org/ticket/1875):
Can somebody on Windows with a IE7 confirm that the fix works?
#1899 (http://trac.turbogears.org/ticket/1889):
Any suggestions how to handle the issue the best way? Or should we
just leave it at documenting it(done) and close it as "wontfix"?
#1956 (http://trac.turbogears.org/ticket/1956):
This one seems to indicate a general issue with CSSSource & JSSource
widgets and XHTML rendering (see my comments on the ticket). Does
anybody have an idea how this is solved best? Alberto maybe?
#1959 (http://trac.turbogears.org/ticket/1959):
I could sort of reproduce this on Mac OS X 10.4. Can anybody else
reproduce this on other systems? Does anybody have an idea as to the
cause?
#1964 (http://trac.turbogears.org/ticket/1964):
I applied this in the 1.1 branch. Should this go into 1.0. as well?
According to the list of ticket types I posted on the trunk list,
that would be a type 5 fix, so I think it can go in.
Chris
Christoph Zwerschke
I'll have a look when I find some time.
-- Christoph
Florent Aide
>
> Hi all,
>
> here is a review of some misc trac tickets concerning milestone
> 1.0.x-bugfix, 1.1 or 1.5 that have open issues and where we need
> feedback. This is just an arbitrary selection of tickets that caught my
> attention, there are a lot more open issues for these milestones. I will
> try to continue this review tomorrow.
I have commented some of those tickets and will continue tonight
before I begin to work on 1.1 beta1.
BTW: Thanks a bunch Chris!
Florent.
Diez B. Roggisch
> This already a year old but seems like a important enough fix
> to put in 1.1. Any volunteers to review the code? Writing a test
> is difficult because the change only concerns JS code.
I fixed this, and assigned it to chrisz as he made me aware of another
mochikit-related bug.
However, there is one culprit with the fix: it will only work with
MK1.4, as MK itself has a bug.
So we should consider defaulting mochikit to 1.4 in TG11 - given the
fact that I use 1.4 for two years now, I don't consider that a bold move.
Diez
Christopher Arndt
>> #1498 (http://trac.turbogears.org/ticket/1498):
> I fixed this, and assigned it to chrisz as he made me aware of another
> mochikit-related bug.
BTW, you got his user name wrong when assigning the ticket (chriz
instead of chrisz). I correctly assigned it to him.
> However, there is one culprit with the fix: it will only work with
> MK1.4, as MK itself has a bug.
> So we should consider defaulting mochikit to 1.4 in TG11
+1 (See also my latest comment on the ticket)
Chris
Jorge Godoy
>
> Diez B. Roggisch schrieb:
>> However, there is one culprit with the fix: it will only work with
>> MK1.4, as MK itself has a bug.
>> So we should consider defaulting mochikit to 1.4 in TG11
>
> +1 (See also my latest comment on the ticket)
+1 from me as well.
Was it 1.1, 1.5 or 2.0 that was targetting to be JS Framework agnostic?
--
Jorge Godoy <jgo...@gmail.com>
Christopher Arndt
Christopher Arndt schrieb:
> here is a review of some misc trac tickets concerning milestone
> 1.0.x-bugfix, 1.1 or 1.5 that have open issues and where we need
> feedback. This is just an arbitrary selection of tickets that caught my
> attention, there are a lot more open issues for these milestones. I will
> try to continue this review tomorrow.
#1498 (http://trac.turbogears.org/ticket/1498): Fixed
#1500 (http://trac.turbogears.org/ticket/1500):
http://docs.turbogears.org/1.1/RoughDocs/Upgrade
Volunteers to fill this page are very welcome!
Florent started putting some text on this but we definitely need to put
more effort in this.
#1796 (http://trac.turbogears.org/ticket/1796): Fixed
#1875 (http://trac.turbogears.org/ticket/1875): Fixed
#1899 (http://trac.turbogears.org/ticket/1889): Fixed
#1956 (http://trac.turbogears.org/ticket/1956): Fixed
#1959 (http://trac.turbogears.org/ticket/1959):
Still unsolved. Any ideas anyone?
#1964 (http://trac.turbogears.org/ticket/1964): Fixed
Christopher Arndt
#1958 http://trac.turbogears.org/ticket/1958:
Solution found, Florent will apply a fix asap.
#1815 http://trac.turbogears.org/ticket/1815
Needs patch.
#1961 http://trac.turbogears.org/ticket/1961
Needs research. There seems to be some problem with JSLink widgets
display in Genshi templates.
#1963 http://trac.turbogears.org/ticket/1963
I proposed three different solutions for this. Needs input from
developers. I also just found another related problem (see comment no.
6). I haven't looked into a solution for that one yet, so any ideas are
appreciated.
#1967 http://trac.turbogears.org/ticket/1967
Needs research and patch. Might be related to #1958 but the
test_config.py module needs to be cleaned up regardless of the solution.
#1969 http://trac.turbogears.org/ticket/1969
I can not reproduce thsi. Ken Kuhlmann nees to re-test and close the ticket.
#1722 http://trac.turbogears.org/ticket/1722
I can not reproduce this. Might be related to the HTML/XHTML isssues
described in #1963, but the ticket does not have enough information to
say for sure. Needs feedback or will be closed as invalid soon.
Chris