Re: [TurboGears] #2396: TG1 Scheduler : Kronos has been updated upstream, we need to reflect improvements
TurboGears
improvements
---------------------------------------+------------------------------------
Reporter: jon | Owner: faide
Type: defect | Status: new
Priority: normal | Milestone: __unclassified__
Component: Scheduler | Version: 1.1
Severity: normal | Resolution:
Keywords: needs feedback, scheduler |
---------------------------------------+------------------------------------
Changes (by Chris Arndt):
* keywords: => needs feedback, scheduler
* owner: => faide
* component: TurboGears => Scheduler
* milestone: => __unclassified__
Comment:
Is there a changelog available? Where did you get information about this
version?
Also, I see somebody has released the turbogears scheduler as a standalone
package on PyPI: http://pypi.python.org/pypi/TGScheduler. There are also
Python 2.6 eggs available.
--
Ticket URL: <http://trac.turbogears.org/ticket/2396#comment:1>
TurboGears <http://www.turbogears.org/>
TurboGears front-to-back web development
TurboGears
improvements
Reporter: jon | Owner:
Priority: normal | Milestone:
Severity: normal | Keywords:
------------------------+---------------------------------------------------
Irmen de Jong has taken the code from TG (making it standalone) and
updated it to be compatible with Python 2.6.
Can we get those improvements as well ?
URL of the new code : http://www.razorvine.net/download/kronos.py
--
Ticket URL: <http://trac.turbogears.org/ticket/2396>
TurboGears
improvements
Reporter: jon | Owner: faide
Component: Scheduler | Version: 1.1
Severity: normal | Resolution:
Keywords: needs feedback, scheduler |
---------------------------------------+------------------------------------
The only change in Irmen's module is the adaption to Py 2.6. The change in
Py 2.6 is that `scheduler.queue` is now a property; the underlying
attribute has been renamed to `scheduler._queue`; `scheduler.queue`
returns a sorted list instead. Also, in Py 2.6 the queue events are now
named tuples.
Not sure whether using the property, i.e. the sorted list, would be a
mistake here, or whether Irmen did this only for performance reasons.
Access as a normal tuple does also still work in Py 2.6 since named tuples
are downward compatible to tuples.
--
Ticket URL: <http://trac.turbogears.org/ticket/2396#comment:2>
TurboGears
improvements
Reporter: jon | Owner: faide
Component: Scheduler | Version: 1.1
Severity: normal | Resolution:
Keywords: needs feedback, scheduler |
---------------------------------------+------------------------------------
* type: defect => enhancement
Comment:
Acording to the pypi package it is based on the file linked. If this is
going to be updated it should be to the pypi package instead of just
updating the bungled version
--
Ticket URL: <http://trac.turbogears.org/ticket/2396#comment:3>
TurboGears
improvements
Reporter: jon | Owner: faide
Priority: normal | Milestone: 1.5
Severity: normal | Resolution:
Keywords: needs feedback, scheduler |
---------------------------------------+------------------------------------
* milestone: __unclassified__ => 1.5
Comment:
Replying to [comment:3 jorge.vargas]:
> Acording to the pypi package it is based on the file linked.
If you look at
[http://code.google.com/p/tgscheduler/source/browse/trunk/TGScheduler/src/TGScheduler/scheduler.py
the source], you'll see it's based on the TurboGears version. Also its
`release.py` file says it's version 1.1 whereas `kronos.py` says it's
version 2.0.
> If this is going to be updated it should be to the pypi package instead
of just updating the bungled version
If we can be sure the package will not be abandoned, I'm all for
maintaining the Scheduler as a separate extension package and removing it
from TG1 in the 1.5 branch, in the same vein as !TurboFeeds and other TG
components, whcih could be made into extension packages. Though I would
prefer that it was hosted on svn.turbogears.org. I see that the google
code project lists several TG mainainers as project owners. We should
contact them and ask them about the status of this package. If I'm not
mistaken, it could even be shared between TG1 and TG2.
One further point to note is that we recently fixed a bug (r6886) in
`scheduler.py`. We should check whether the other versions contain this
fix too.
--
Ticket URL: <http://trac.turbogears.org/ticket/2396#comment:4>
TurboGears
improvements
Reporter: jon | Owner: vinces1979
Type: enhancement | Status: new
Priority: normal | Milestone: 1.5
Component: Scheduler | Version: 1.1
Severity: normal | Resolution:
Keywords: needs feedback, scheduler |
---------------------------------------+------------------------------------
Changes (by Chris Arndt):
* owner: faide => vinces1979
Comment:
Vince has now migrated his TGScheduler package into our repository:
source:project/TGScheduler. Im assigning this ticket to him so he can
close it when he has integrated the upstream changes.
--
Ticket URL: <http://trac.turbogears.org/ticket/2396#comment:5>
TurboGears
improvements
Reporter: jon | Owner: vinces1979
Type: enhancement | Status: new
Priority: normal | Milestone: 1.5
Component: Scheduler | Version: 1.1
Severity: normal | Resolution:
Keywords: needs feedback, scheduler |
---------------------------------------+------------------------------------
Vince, can we close this ticket now?
--
Ticket URL: <http://trac.turbogears.org/ticket/2396#comment:6>
TurboGears
improvements
Reporter: jon | Owner: vinces1979
Component: Scheduler | Version: 1.1
---------------------------------------+------------------------------------
* status: new => closed
* resolution: => fixed
Comment:
Replying to [comment:6 Chris Arndt]:
> Vince, can we close this ticket now?
Yeah Chris this has been implemented and tested
--
Ticket URL: <http://trac.turbogears.org/ticket/2396#comment:7>