tup error: Tupid is -1 in tup_entry_add() when using top level rules file with variants

[Nicholas Walton]

This took a bit of tracking down, and I don't know what's causing it. Seems to only happen with a top level Tuprules.tup and a Tupfile with include_rules.

$ ./tXXXX-variant-rules.sh
.tup repository initialized.
tup: Added variant 'build-debug' using config file 'configs/debug.config'
tup: Added variant 'build-default' using config file 'configs/default.config'
[ tup ] [0.000s] Scanning filesystem...
[ tup ] [0.006s] Reading in new configuration/environment variables...
 1) new variant: build-debug/tup.config
 2) new variant: build-default/tup.config                                                 
[ tup ] [0.009s] Parsing Tupfiles...                                                      
 1) [0.001s] build-default/configs
 2) [0.001s] build-debug/configs                                                          
tup error: Tupid is -1 in tup_entry_add()
* 3) [0.001s] build-default                                                               
Error parsing Tupfile line 1
  Line was: 'include_rules'
 *** tup: 1 job failed.
*** Failed to update!

[Mike Shal]

I think the 'Tupid is -1' error was actually just fixed in
b45ac0815343 (pushed out around the time you sent this email).
However, your test case did point me to another issue, which was that
include_rules inside a variant was trying to include the top-level
Tuprules.tup file twice. I've changed your test case slightly and
pushed it out in t8061 to fix this.

Thanks for the feedback - let me know if you come across any other
issues with it! I am almost finished with the variants branch, so any
other issues like this are almost certainly bugs :)

-Mike