[TTK 1.2 + Paraview 5.11.1] Infinite density in CSP computed for the tooth dataset

[Mohit Sharma]

Hi,

The density range is [0, infinity] in the CSP computed for the tooth dataset with TTK 1.2. It works perfectly fine with TTK 0.9.8. Here is the dataset file.

Thanks,

Mohit Sharma

[Julien Tierny]

Dear Mohit,

thanks for your email.

Can you please open an issue about this?
(there: https://github.com/topology-tool-kit/ttk/issues)

Thanks!

Best,
--
Dr Julien Tierny
CNRS Researcher
Sorbonne Universite
https://julien-tierny.github.io/

On Monday, 20 November 2023 09:17:26 CET Mohit Sharma wrote:
> Hi,
>
> The density range is [0, infinity] in the CSP computed for the tooth
> dataset with TTK 1.2. It works perfectly fine with TTK 0.9.8. Here

> <https://drive.google.com/file/d/1mB27l0R5sCCPrjY2bxwvgKyMyXFvWK1o/view?usp=sharing>

[Domantas Dilys]

I've spotted this with my own netcdf dataset on TTK 1.2/Paraview 5.12 (did not work on both Windows 11 and RHLE 8). CSP worked on both TTK 1.0.0 and 1.1.0 for the same dataset. Looking at the sourcecode (https://topology-tool-kit.github.io/doc/html/ContinuousScatterPlot_8h_source.html) the infinity comes from: `if(isLimit) density = std::numeric_limits<decltype(density)>::max();`, where `isLimit` is set to true when the triangle area is 0.0 - so I suspect the bug might be centered around `Geometry::computeTriangleArea(data[index[0]], data[index[1]], data[index[2]], A);`, where I see the triangle indices have been updated in the newer code (https://github.com/topology-tool-kit/ttk/pull/920/files - lines 270-288), but not in computeTriangleArea()when passing those triangle indices.

[Julien Tierny]

Thanks a lot Domantas for your feedback.
Would you mind submitting a PR?
Thanks!

--
Dr Julien Tierny
CNRS Researcher
Sorbonne Universite
https://julien-tierny.github.io/

On Thursday, 23 November 2023 15:38:00 CET Domantas Dilys wrote:
> I've spotted this with my own netcdf dataset on TTK 1.2/Paraview 5.12 (did
> not work on both Windows 11 and RHLE 8). CSP worked on both TTK 1.0.0 and
> 1.1.0 for the same dataset. Looking at the sourcecode
> (https://topology-tool-kit.github.io/doc/html/ContinuousScatterPlot_8h_source.html)
> the infinity comes from: `if(isLimit) density = std::numeric_limits<decltype
> (density)>::max();`, where `isLimit` is set to true when the triangle area
> is 0.0 - so I suspect the bug might be centered around `Geometry::computeTriangleArea(data[index[0]],
> data[index[1]], data[index[2]], A);`, where I see the triangle indices have
> been updated in the newer code
> (https://github.com/topology-tool-kit/ttk/pull/920/files - lines 270-288),
> but not in computeTriangleArea()when passing those triangle indices.
>
> On Monday, 20 November 2023 at 08:37:54 UTC Julien Tierny wrote:
>
> > Dear Mohit,
> >
> > thanks for your email.
> >
> > Can you please open an issue about this?
> > (there: https://github.com/topology-tool-kit/ttk/issues)
> >
> > Thanks!
> >
> > Best,
> >