Lag Selection

33 views
Skip to first unread message

Daisuke Mori

unread,
Oct 3, 2019, 5:44:01 PM10/3/19
to tsdyn
Dear Matthieu,

When I used "lags.select" in tsDyn, I found that "best number of lags" of HQ is not correct and it is always the same as the number of BICs.
So, I checked the content of S3method "summary" of rank.select, I found the following code.
HQ_minlag<-apply(object$BICs, 1, which.min)

I wonder if it should be "HQ_minlag<-apply(object$HQs, 1, which.min)".


Sincerely,
Daisuke

Matthieu S

unread,
Oct 3, 2019, 5:46:00 PM10/3/19
to ts...@googlegroups.com, daisuk...@gmail.com
Well spotted, this is indeed a mistake, thanks for reporting!

I just commited a bug fix commit on the Dev branch: https://github.com/MatthieuStigler/tsDyn/commits/Dev94/tsDyn

You can install it with:
library(remotes)
install_github("MatthieuStigler/tsDyn/tsDyn", ref = "Dev94")

Best
MAtthieu

--
You received this message because you are subscribed to the Google Groups "tsdyn" group.
To unsubscribe from this group and stop receiving emails from it, send an email to tsdyn+un...@googlegroups.com.
To view this discussion on the web visit https://groups.google.com/d/msgid/tsdyn/9a354a56-691f-49d9-bbd7-728e6a5ffcb9%40googlegroups.com.
Reply all
Reply to author
Forward
0 new messages