tryton: Refactorize date widgets (issue373001)

[cedric...@b2ck.com]

Reviewers: ,



Please review this at http://codereview.tryton.org/373001/

Affected files:
M CHANGELOG
M doc/usage.rst
M tryton/common/cellrendererdate.py
M tryton/common/date_widget.py
M tryton/gui/window/shortcuts.py
M tryton/gui/window/view_form/view/form_gtk/calendar.py
M tryton/gui/window/view_form/view/list_gtk/parser.py

[Cédric Krier]

I would like to have some comments and testing on this change because it
affects the behavior of the date widgets.
And I don't know if people who are used to the old one will find this
one good enough.

--
Cédric Krier

B2CK SPRL
Rue de Rotterdam, 4
4000 Liège
Belgium
Tel: +32 472 54 46 59
Email/Jabber: cedric...@b2ck.com
Website: http://www.b2ck.com/

[Cédric Krier]

On 30/05/12 14:57 +0200, Cédric Krier wrote:
> On 16/05/12 16:38 +0000, cedric...@b2ck.com wrote:
> > Reviewers: ,
> >
> >
> >
> > Please review this at http://codereview.tryton.org/373001/
> >
> > Affected files:
> > M CHANGELOG
> > M doc/usage.rst
> > M tryton/common/cellrendererdate.py
> > M tryton/common/date_widget.py
> > M tryton/gui/window/shortcuts.py
> > M tryton/gui/window/view_form/view/form_gtk/calendar.py
> > M tryton/gui/window/view_form/view/list_gtk/parser.py
>
> I would like to have some comments and testing on this change because it
> affects the behavior of the date widgets.
> And I don't know if people who are used to the old one will find this
> one good enough.

So nobody cares about the drop of the small computation in date widget
for a simple +/-1 shortcut.

[Cédric Krier]

On 30/05/12 14:57 +0200, Cédric Krier wrote:

> On 16/05/12 16:38 +0000, cedric...@b2ck.com wrote:
> > Reviewers: ,
> >
> >
> >
> > Please review this at http://codereview.tryton.org/373001/
> >
> > Affected files:
> > M CHANGELOG
> > M doc/usage.rst
> > M tryton/common/cellrendererdate.py
> > M tryton/common/date_widget.py
> > M tryton/gui/window/shortcuts.py
> > M tryton/gui/window/view_form/view/form_gtk/calendar.py
> > M tryton/gui/window/view_form/view/list_gtk/parser.py
>
> I would like to have some comments and testing on this change because it
> affects the behavior of the date widgets.
> And I don't know if people who are used to the old one will find this
> one good enough.

I changed the behavior to be lower case increase and upper case
decrease. I find it more logical to have by default increase.

PS: I would really have feedback on this patch because I would like to
push it.

[Mathias Behrle]

* Betr.: " Re: [tryton-dev] tryton: Refactorize date widgets
(issue373001)" (Wed, 25 Jul 2012 15:25:39 +0200):

> On 30/05/12 14:57 +0200, Cédric Krier wrote:
> > On 16/05/12 16:38 +0000, cedric...@b2ck.com wrote:
> > > Reviewers: ,
> > >
> > >
> > >
> > > Please review this at http://codereview.tryton.org/373001/
> > >
> > > Affected files:
> > > M CHANGELOG
> > > M doc/usage.rst
> > > M tryton/common/cellrendererdate.py
> > > M tryton/common/date_widget.py
> > > M tryton/gui/window/shortcuts.py
> > > M tryton/gui/window/view_form/view/form_gtk/calendar.py
> > > M tryton/gui/window/view_form/view/list_gtk/parser.py
> >
> > I would like to have some comments and testing on this change because it
> > affects the behavior of the date widgets.
> > And I don't know if people who are used to the old one will find this
> > one good enough.
>
> I changed the behavior to be lower case increase and upper case
> decrease. I find it more logical to have by default increase.

+1

Same for me, when I tested first time.

> PS: I would really have feedback on this patch because I would like to
> push it.

Will test again, if I have a little spare time.



--

Mathias Behrle
MBSolutions
Gilgenmatten 10 A
D-79114 Freiburg

Tel: +49(761)471023
Fax: +49(761)4770816
http://m9s.biz
UStIdNr: DE 142009020
PGP/GnuPG key availabable from any keyserver, ID: 0x8405BBF6