Adding CI to sao

39 views
Skip to first unread message

Sergi Almacellas Abellana

unread,
May 11, 2016, 7:52:40 AM5/11/16
to tryto...@googlegroups.com
Hi,

I just realized that sao is not currently build on drone so the packaged
can be easly broken, for example [1].

I uploaded a review[2] that asks a grunt task to run the packages and
qunit tests. It also adds the drone configuration. So with this review
you can easly run:

npm test

Which will build the package and run the qunit test. Comments and
feedback is very welcome.

I have runned it on the drone.io server. You can see the results here [3].

I'm wondering which will be the required steps to make it run on
drone.tryton.org

[1] http://hg.tryton.org/sao/rev/59bece7f8e74
[2] https://tryton-rietveld.appspot.com/24221002
[3] https://drone.io/bitbucket.org/pokoli/sao/

--
Sergi Almacellas Abellana
www.koolpi.com
Twitter: @pokoli_srk

Cédric Krier

unread,
May 11, 2016, 8:30:02 AM5/11/16
to tryto...@googlegroups.com
On 2016-05-11 13:52, Sergi Almacellas Abellana wrote:
> Hi,
>
> I just realized that sao is not currently build on drone so the packaged can
> be easly broken, for example [1].

I was also thinking about it.
Having also tests on tryton will be great.

> I uploaded a review[2] that asks a grunt task to run the packages and qunit
> tests. It also adds the drone configuration. So with this review you can
> easly run:
>
> npm test
>
> Which will build the package and run the qunit test. Comments and feedback
> is very welcome.
>
> I have runned it on the drone.io server. You can see the results here [3].

Can not see it.

> I'm wondering which will be the required steps to make it run on
> drone.tryton.org

The activation requires some manual step for now. So I will activate it
once we have your patch.

--
Cédric Krier - B2CK SPRL
Email/Jabber: cedric...@b2ck.com
Tel: +32 472 54 46 59
Website: http://www.b2ck.com/

Sergi Almacellas Abellana

unread,
May 11, 2016, 9:15:54 AM5/11/16
to tryto...@googlegroups.com
El 11/05/16 a les 14:29, Cédric Krier ha escrit:
> On 2016-05-11 13:52, Sergi Almacellas Abellana wrote:
>> Hi,
>>
>> I just realized that sao is not currently build on drone so the packaged can
>> be easly broken, for example [1].
>
> I was also thinking about it.
> Having also tests on tryton will be great.

Yes that will be great also.

>
>> I uploaded a review[2] that asks a grunt task to run the packages and qunit
>> tests. It also adds the drone configuration. So with this review you can
>> easly run:
>>
>> npm test
>>
>> Which will build the package and run the qunit test. Comments and feedback
>> is very welcome.
>>
>> I have runned it on the drone.io server. You can see the results here [3].
>
> Can not see it.

Its running here:

https://drone.io/bitbucket.org/pokoli/sao
>
>> I'm wondering which will be the required steps to make it run on
>> drone.tryton.org
>
> The activation requires some manual step for now. So I will activate it
> once we have your patch.
>

Ok, so I will let you know when the patch is ready.

Cédric Krier

unread,
May 11, 2016, 9:50:02 AM5/11/16
to tryto...@googlegroups.com
On 2016-05-11 15:15, Sergi Almacellas Abellana wrote:
> Its running here:
>
> https://drone.io/bitbucket.org/pokoli/sao

I see it does a lot of http requests. Is it possible to have some
caching? Like I did with devpi [1]

[1] http://downloads.tryton.org/TUBA2015/mr_robot/mgp00020.html

Cédric Krier

unread,
May 11, 2016, 10:10:02 AM5/11/16
to tryto...@googlegroups.com
On 2016-05-11 15:15, Sergi Almacellas Abellana wrote:
> >The activation requires some manual step for now. So I will activate it
> >once we have your patch.
> >
>
> Ok, so I will let you know when the patch is ready.

Normally everything is ready now. So when you will push a .drone.yml
file to sao repository the build will be triggered.

Sergi Almacellas Abellana

unread,
May 11, 2016, 10:35:29 AM5/11/16
to tryto...@googlegroups.com
El 11/05/16 a les 15:46, Cédric Krier ha escrit:
> On 2016-05-11 15:15, Sergi Almacellas Abellana wrote:
>> Its running here:
>>
>> https://drone.io/bitbucket.org/pokoli/sao
>
> I see it does a lot of http requests. Is it possible to have some
> caching? Like I did with devpi [1]
>

Don't know much about npm, but local-npm [2] seems to me that is the
devpi equivalent.

So AFAIU, you have to install local-npm and use the NPM_CONFIG_REGISTRY
environment variable to define url of where the local server is listening.

[2] https://www.npmjs.com/package/local-npm
> [1] http://downloads.tryton.org/TUBA2015/mr_robot/mgp00020.html

Cédric Krier

unread,
May 11, 2016, 10:55:03 AM5/11/16
to tryto...@googlegroups.com
On 2016-05-11 16:35, Sergi Almacellas Abellana wrote:
> El 11/05/16 a les 15:46, Cédric Krier ha escrit:
> >On 2016-05-11 15:15, Sergi Almacellas Abellana wrote:
> >>Its running here:
> >>
> >>https://drone.io/bitbucket.org/pokoli/sao
> >
> >I see it does a lot of http requests. Is it possible to have some
> >caching? Like I did with devpi [1]
> >
>
> Don't know much about npm, but local-npm [2] seems to me that is the devpi
> equivalent.
>
> So AFAIU, you have to install local-npm and use the NPM_CONFIG_REGISTRY
> environment variable to define url of where the local server is listening.

It sounds good. I will try to set on tycho once we have sao builds.

Sergi Almacellas Abellana

unread,
May 12, 2016, 3:19:48 AM5/12/16
to tryto...@googlegroups.com
El 11/05/16 a les 16:52, Cédric Krier ha escrit:
> On 2016-05-11 16:35, Sergi Almacellas Abellana wrote:
>> >El 11/05/16 a les 15:46, Cédric Krier ha escrit:
>>> > >On 2016-05-11 15:15, Sergi Almacellas Abellana wrote:
>>>> > >>Its running here:
>>>> > >>
>>>> > >>https://drone.io/bitbucket.org/pokoli/sao
>>> > >
>>> > >I see it does a lot of http requests. Is it possible to have some
>>> > >caching? Like I did with devpi [1]
>>> > >
>> >
>> >Don't know much about npm, but local-npm [2] seems to me that is the devpi
>> >equivalent.
>> >
>> >So AFAIU, you have to install local-npm and use the NPM_CONFIG_REGISTRY
>> >environment variable to define url of where the local server is listening.
> It sounds good. I will try to set on tycho once we have sao builds.
We know have the first build [1],

but from the output of drone it seems that the .drone.yml file is not
executed so the package is not build nor the tests have ran.

Have I missed something?


[1]
https://drone.tryton.org/trypod.tryton.org/tryton/sao/default/e9b53490682632b2a379feda291a98b879f0b3fb

Cédric Krier

unread,
May 12, 2016, 4:45:03 AM5/12/16
to tryto...@googlegroups.com
On 2016-05-12 09:19, Sergi Almacellas Abellana wrote:
> El 11/05/16 a les 16:52, Cédric Krier ha escrit:
> >On 2016-05-11 16:35, Sergi Almacellas Abellana wrote:
> >>>El 11/05/16 a les 15:46, Cédric Krier ha escrit:
> >>>> >On 2016-05-11 15:15, Sergi Almacellas Abellana wrote:
> >>>>> >>Its running here:
> >>>>> >>
> >>>>> >>https://drone.io/bitbucket.org/pokoli/sao
> >>>> >
> >>>> >I see it does a lot of http requests. Is it possible to have some
> >>>> >caching? Like I did with devpi [1]
> >>>> >
> >>>
> >>>Don't know much about npm, but local-npm [2] seems to me that is the devpi
> >>>equivalent.
> >>>
> >>>So AFAIU, you have to install local-npm and use the NPM_CONFIG_REGISTRY
> >>>environment variable to define url of where the local server is listening.
> >It sounds good. I will try to set on tycho once we have sao builds.
> We know have the first build [1],
>
> but from the output of drone it seems that the .drone.yml file is not
> executed so the package is not build nor the tests have ran.
>
> Have I missed something?

The syntax was not right.

It is fixed now and also cache of npm and bower is setup. The only thing
expensive left is the download of the phantomjs image, see
https://drone.tryton.org/trypod.tryton.org/tryton/sao/default/1e58052bb56f69d1a329d5b6a4655be48ed1f085
Reply all
Reply to author
Forward
0 new messages