[tx-trac] #221: Two edits in the same time causes bad things to happen

[Transifex Trac]

#221: Two edits in the same time causes bad things to happen
--------------------+-------------------------------------------------------
Reporter: Raven | Owner: glezos
Type: defect | Status: new
Priority: major | Milestone:
Component: Core | Version:
Keywords: | Easy_task: 0
Review: | Blockedby:
Blocking: |
--------------------+-------------------------------------------------------
When two admins edit the same thing in the same time, Transifex lost one's
work. That kind of behavior should be prevented.

--
Ticket URL: <http://transifex.org/ticket/221>
Transifex <http://transifex.org/>
Integrated translation platform

[Transifex Trac]

#221: Two edits in the same time causes bad things to happen
--------------------+-------------------------------------------------------
Reporter: Raven | Owner: glezos
Type: defect | Status: new

Priority: major | Milestone: 0.8
Component: Core | Version:
Keywords: | Easy_task: 1
Review: | Blockedby:
Blocking: | Needs_patch: 1
--------------------+-------------------------------------------------------
Changes (by glezos):

* milestone: => 0.8
* needs_patch: => 1
* easy_task: 0 => 1

--
Ticket URL: <http://transifex.org/ticket/221#comment:1>

[Transifex Trac]

#221: Two edits in the same time causes bad things to happen
--------------------+-------------------------------------------------------

Reporter: Raven | Owner: korki
Type: defect | Status: assigned
Priority: minor | Milestone: 0.8.1
Component: Core | Version:
Keywords: | Easy_task: 1
Blockedby: | Blocking:
Review: | Needs_patch: 1
--------------------+-------------------------------------------------------
Changes (by glezos):

* owner: => korki
* priority: major => minor
* status: new => assigned
* milestone: 0.8 => 0.8.1

Comment:

This is quite easy:

- In the Edit View, add a cache flag `{"project.is_being_edited":
"username.timestamp"}.
- This should have a default expiration time of eg. 10 minutes.
- When the edit succeeds, the flag is expired.
- The view should check: "check the flag: if the user is not the user
holding the flag, don't allow editing."

This should be implemented as a reusable decorator. It might as well
already exist in other Django apps.

--
Ticket URL: <http://transifex.org/ticket/221#comment:3>

[Transifex Trac]

#221: Two edits in the same time causes bad things to happen

---------------------------+------------------------------------------------

Reporter: Raven | Owner: korki
Type: defect | Status: assigned

Priority: minor | Milestone: Sometime...
Component: Core | Version: devel

Keywords: | Easy_task: 1
Blockedby: | Blocking:

Ready_for_review: 0 | Review:
Needs_patch: 1 |
---------------------------+------------------------------------------------
Changes (by diegobz):

* version: => devel
* ready_for_review: => 0
* milestone: 0.8.1 => Sometime...

--
Ticket URL: <http://transifex.org/ticket/221#comment:4>

[Transifex Trac]

#221: Two edits in the same time causes bad things to happen

----------------------------+----------------------------
Reporter: Raven | Owner: korki
Type: defect | Status: closed

Priority: minor | Milestone: Sometime...
Component: Core | Version: devel

Resolution: invalid | Keywords:
Blocked By: | Blocking:
Easy Task: 1 | Needs Patch: 1
Ready for Review: 0 | Patch Review:
----------------------------+----------------------------
Changes (by jkal):

* status: assigned => closed
* resolution: => invalid

--
Ticket URL: <http://transifex.org/ticket/221#comment:5>