[tx-trac] #620: Cannot dismiss lang team request notice if lang team was created manually.

[Transifex Trac]

#620: Cannot dismiss lang team request notice if lang team was created manually.
-----------------------------+----------------------------------------------
Reporter: nkinkade | Owner:
Type: defect | Status: new
Priority: minor | Milestone:
Component: Core | Version: devel
Keywords: | Easy_task: 0
Blockedby: | Blocking:
Ready_for_review: 0 | Review:
Needs_patch: 1 |
-----------------------------+----------------------------------------------
For our project at Transifex.net (http://www.transifex.net/projects/p/CC/)
we received a request to create a French translation team. At that time,
for some reason I didn't see the notice under "Translation Teams" to
approve or deny the request. Instead I used the "Add a new team" button
to create the French team and I manually added the original requester to
the team.

I then found that I could not dismiss the notice by clicking the "Approve"
button. When I clicked the Approve button the page refreshed but the
notice remained. In order to dismiss the notice I had to click the "Deny"
button, which sent an email to me, and I'm sure also the original
requester. This is probably confusing for that person.

To repeat bug:

1) Login as an unprivileged, normal Transifex.net user, and request a
language team for a given project.

2) Login to Transifex.net as a privileged user for the given project.

3) Rather than clicking "Approve" to approve the team creation request,
use the "Add a new team" button, then manually add the user from step 1 to
the team.

4) Now go back and try to "Approve" the request using the button on the
notice.

Nothing happens except the page reloads, and the notice remains. You must
click the "Deny" button to get the notice to go away.

Expected result: When I clicked Approve, the system should have noted that
the team was already created, then checked to see if the requesting user
was already part of the team. If so, just dismiss the notice. If not,
then add the user to the team and send the requester an email letting them
know they were added.

--
Ticket URL: <http://transifex.org/ticket/620>
Transifex <http://transifex.org/>
Integrated translation platform

[Transifex Trac]

#620: Cannot dismiss lang team request notice if lang team was created manually.
-----------------------------+----------------------------------------------
Reporter: nkinkade | Owner:
Type: defect | Status: new
Priority: minor | Milestone:
Component: Core | Version: devel
Keywords: | Easy_task: 0
Blockedby: | Blocking:
Ready_for_review: 0 | Review:
Needs_patch: 1 |
-----------------------------+----------------------------------------------

Comment(by glezos):

If I understand correctly, what needs to be done here is the following:

After I manually add a team, then Transifex should check whether a request
already exists. If it does, remove it (without denying it), since the team
has already been added and a request doesn't make sense any more.

Yes?

--
Ticket URL: <http://transifex.org/ticket/620#comment:1>

[Transifex Trac]

#620: Cannot dismiss lang team request notice if lang team was created manually.
-----------------------------+----------------------------------------------
Reporter: nkinkade | Owner:
Type: defect | Status: new
Priority: minor | Milestone:
Component: Core | Version: devel
Keywords: | Easy_task: 0
Blockedby: | Blocking:
Ready_for_review: 0 | Review:
Needs_patch: 1 |
-----------------------------+----------------------------------------------

Comment(by nkinkade):

That is certainly one possibility ... to have the system remove it
automatically. I think that makes sense, if the team exists *and* the
requesting user is already part of the team. The other possibility, which
is the one I described above, is to leave the notice and let the admin
click the "Approve" button, which would simply check to see if the
requester was already part of the created team, and if not, add that user
to the team, then dismiss the dialog.

I'm open to any solution, but one way or another in an ideal world it
should be possible to dismiss or have that notice go away without the
admin having to manually Deny the request, which is confusing.

--
Ticket URL: <http://transifex.org/ticket/620#comment:2>

[Transifex Trac]

#620: Cannot dismiss lang team request notice if lang team was created manually.
-----------------------------+-----------------------

Reporter: nkinkade | Owner:
Type: defect | Status: closed

Priority: minor | Milestone:
Component: Core | Version: devel

Resolution: wontfix | Keywords:
Blocked By: | Blocking:
Easy Task: 0 | Needs Patch: 1
Ready for Review: 0 | Patch Review:
-----------------------------+-----------------------
Changes (by mpessas):

* status: new => closed
* resolution: => wontfix

Comment:

Hi,

Trac is bein shut down, so all tickets are either closed or moved. This
specific one is very old and in the mean time a lot of the code has been
changed, while other changes are in development. If the issue persists,
feel free to open a new issue in https://github.com/transifex/transifex.

Thanks,
Apostolis

--
Ticket URL: <http://transifex.org/ticket/620#comment:3>