Re: Use RuntimeInliner to provide the generator common code. (re-remove TODOs) (issue 7487046)

1 view
Skip to first unread message

usrb...@yahoo.com

unread,
Mar 15, 2013, 12:21:58 PM3/15/13
to a...@chromium.org, traceur-comp...@googlegroups.com, re...@codereview-hr.appspotmail.com

https://codereview.appspot.com/7487046/diff/6001/src/codegeneration/generator/GeneratorTransformer.js
File src/codegeneration/generator/GeneratorTransformer.js (right):

https://codereview.appspot.com/7487046/diff/6001/src/codegeneration/generator/GeneratorTransformer.js#newcode239
src/codegeneration/generator/GeneratorTransformer.js:239: // TODO: Look
into if this code can be shared between generator
While working on the next patch, I realized that this part snuck back in
during a merge snafu. Removing it again. Hopefully it doesn't reanimate.

https://codereview.appspot.com/7487046/

a...@chromium.org

unread,
Mar 17, 2013, 1:03:06 PM3/17/13
to usrb...@yahoo.com, traceur-comp...@googlegroups.com, re...@codereview-hr.appspotmail.com
LGTM


https://codereview.appspot.com/7487046/diff/10002/src/codegeneration/generator/GeneratorTransformer.js
File src/codegeneration/generator/GeneratorTransformer.js (right):

https://codereview.appspot.com/7487046/diff/10002/src/codegeneration/generator/GeneratorTransformer.js#newcode238
src/codegeneration/generator/GeneratorTransformer.js:238: var
$generatorWrap = this.runtimeInliner_.get('generatorWrap',
no need to prefix this with $

https://codereview.appspot.com/7487046/
Reply all
Reply to author
Forward
0 new messages