Groups
Groups
Sign in
Groups
Groups
Traceur Compiler Reviews
Conversations
About
Send feedback
Help
Re: Add parse tree writer round trip testing to feature tests. (issue 7832045)
3 views
Skip to first unread message
a...@chromium.org
unread,
Mar 27, 2013, 7:34:16 PM
3/27/13
Reply to author
Sign in to reply to author
Forward
Sign in to forward
Delete
You do not have permission to delete messages in this group
Copy link
Report message
Show original message
Either email addresses are anonymous for this group or you need the view member email addresses permission to view the original message
to pete...@google.com, traceur-comp...@googlegroups.com, re...@codereview-hr.appspotmail.com
LGTM
I can merge this to GitHub if you want to commit this to Google Code.
https://codereview.appspot.com/7832045/diff/1/src/outputgeneration/ParseTreeWriter.js
File src/outputgeneration/ParseTreeWriter.js (left):
https://codereview.appspot.com/7832045/diff/1/src/outputgeneration/ParseTreeWriter.js#oldcode107
src/outputgeneration/ParseTreeWriter.js:107: this.write_(OPEN_SQUARE);
oops
https://codereview.appspot.com/7832045/diff/1/test/testfeatures.js
File test/testfeatures.js (right):
https://codereview.appspot.com/7832045/diff/1/test/testfeatures.js#newcode124
test/testfeatures.js:124: '\n\ + e');
+2 indent
https://codereview.appspot.com/7832045/
Reply all
Reply to author
Forward
0 new messages