Reduce code duplication due to FunctionDeclaration and FunctionExpression (issue 7693051)

[a...@chromium.org]

Reviewers: peterhal,

Description:
Reduce code duplication due to FunctionDeclaration and
FunctionExpression

BUG=None


Please review this at https://codereview.appspot.com/7693051/

Affected files:
M bin/traceur.js
M src/codegeneration/DefaultParametersTransformer.js
M src/codegeneration/DestructuringTransformer.js
M src/codegeneration/GeneratorTransformPass.js
M src/codegeneration/SuperTransformer.js
M src/outputgeneration/ParseTreeWriter.js
M src/syntax/ParseTreeValidator.js

[Erik Arvidsson]

Unfortunately comments are not allowed in JSON.

On Mar 19, 2013 5:36 PM, <pete...@google.com> wrote:

LGTM

Thanks for taking care of this for me.

This looks great - I particularly like explicitly passing in the
constructor as a parameter rather than the tree.constructor method.

The one thing I'd add is a comment in trees.json detailing that there is
code which relies on FunctionExpression and FunctionDeclaration having
the same structure.

https://codereview.appspot.com/7693051/

[a...@chromium.org]

How about this? Is it too hacky?

https://codereview.appspot.com/7693051/

[a...@chromium.org]

Committed patchset #3 manually as r6040890 (presubmit successful).

https://codereview.appspot.com/7693051/