Fix reading files on windows. (issue 8238043)

[pe...@peterhallam.com]

Reviewers: arv-chromium,

Message:
This gets traceur working on Windows for me.

Description:
Fix reading files on windows.


BUG=


Please review this at https://codereview.appspot.com/8238043/

Affected files:
M build/build-test-list.js


Index: build/build-test-list.js
diff --git a/build/build-test-list.js b/build/build-test-list.js
old mode 100644
new mode 100755
index
0fec48c32f7b8167323800fc37962fd0ff0d71c4..6dd6162530e622870ad38bc6d786abd5ed39abde
--- a/build/build-test-list.js
+++ b/build/build-test-list.js
@@ -16,8 +16,6 @@

var fs = require('fs');

-var STDIN_FILENO = 0;
-
/**
* Returns all input read from |fd| as a string, correctly handling ending
of
* piped input.
@@ -31,13 +29,20 @@ function readSyncString(fd) {
var len = 0;
var text = '';

- while (len = fs.readSync(fd, buf, 0, BUFFER_SIZE, null)) {
- text += buf.toString('utf8', 0, len);
+ try {
+ while (len = fs.readSync(fd, buf, 0, BUFFER_SIZE, null)) {
+ text += buf.toString('utf8', 0, len);
+ }
+ } catch (e) {
+ // On Windows readSync throws if attempting to read at EOF
+ if (e.message.indexOf('EOF') != 0) {
+ throw e;
+ }
}
return text;
}

-var lines = readSyncString(STDIN_FILENO).split('\n').filter(function(x) {
+var lines =
readSyncString(process.stdin.fd).split('\n').filter(function(x) {
// JS files only
return x && x.match('\\.js$');
}).map(function(x) {

[a...@chromium.org]

LGTM

Do you mind sending a pull request on github instead?

https://codereview.appspot.com/8238043/