Re: Add isStopIteration to '@iter' module. Update the tests to use it. (issue 7610045)

1 view
Skip to first unread message

usrb...@yahoo.com

unread,
Mar 30, 2013, 12:32:28 PM3/30/13
to a...@chromium.org, sligh...@google.com, traceur-comp...@googlegroups.com, re...@codereview-hr.appspotmail.com
Note: I'm just cleaning out old issues. New patches will go through
github once I get up to speed on it.

----

Patch order at a glance:

## you are here
Add isStopIteration to '@iter' module. Update the tests to use it.
https://codereview.appspot.com/7610045/
Fix setting of StopIteration and GeneratorReturn.
https://codereview.appspot.com/7757044/

----

I know I said before that this patch series should just be ignored, but
waiting for consensus on iterators is probably not a good strategy. This
is a pretty small patch series, and it's blocking me from fixing some
other bugs.

I mean, I could hack around it, but the code is already here, and bugs
are still bugs. Might as well just fix it so we can play with a working
implementation before the spec changes.

----

#--cut--
dl_check() {
local f=$(basename $1)
test -e $f || curl -sO $1
openssl sha1 < $f | grep -q "= $2" && return 0
echo sha1 mismatch! && return 1
}

git checkout 4b95bde73a18eb81 # last merge with branch master

git checkout -b issue7757044-stopiteration-fix

## you are here
dl_check https://codereview.appspot.com/download/issue7610045_3001.diff
\
f6fe7fd74cd4e6a7 && git apply issue7610045_3001.diff && make test
#git commit -m issue7610045_3001.diff

## force test-list remake since we're about to add a test.
rm test/test-list.js

dl_check https://codereview.appspot.com/download/issue7757044_10001.diff
\
56c03866b252d5c9 && git apply issue7757044_10001.diff && make test
#git commit -m issue7757044_10001.diff

## To undo all the above repo changes
#git reset --hard
#git checkout master
#git branch -D issue7757044-stopiteration-fix
#--cut--


https://codereview.appspot.com/7610045/

a...@chromium.org

unread,
Apr 2, 2013, 2:02:18 PM4/2/13
to usrb...@yahoo.com, sligh...@google.com, traceur-comp...@googlegroups.com, re...@codereview-hr.appspotmail.com
LGTM

Committed as eb43f08a1c9ef51295a166e21a8f76704b7e3be0

https://codereview.appspot.com/7610045/
Reply all
Reply to author
Forward
0 new messages