Use npm package for closure-library (issue 7972044)

[a...@chromium.org]

Reviewers: peterhal, usrbincc,

Message:
This deletes thousands of files from our repo =D

Description:
Use npm package for closure-library

BUG=https://code.google.com/p/traceur-compiler/issues/detail?id=205


Please review this at https://codereview.appspot.com/7972044/

Affected files:
M package.json
M test/alltests.html
M test/feature/feature_test.html
M test/system/hello_test.html
M test/unit/codegeneration/low_level_tests.html
M test/unit/codegeneration/placeholder_parser_test.html
M test/unit/codegeneration/runtime_inliner_test.html
M test/unit/codegeneration/source_map_test.html
M test/unit/codegeneration/writer_test.html
M test/unit/runtime/modules_test.html
M test/unit/semantics/free_variable_checker_test.html
M test/unit/semantics/variable_binder_test.html
M test/unit/syntax/line_numbers.html
M test/unit/syntax/parser_test.html
M test/unit/syntax/parsetreevalidator_test.html
M test/unit/syntax/token_test.html
M test/unit/util/error_reporter_test.html
M test/unit/util/url_test.html
D third_party/closure-library/AUTHORS
D third_party/closure-library/LICENSE
D third_party/closure-library/README
D third_party/closure-library/all_tests.html
D third_party/closure-library/alltests.js
D third_party/closure-library/closure/css/inlay/g-base.css
D third_party/closure-library/closure/css/inlay/g-fixed.css
D third_party/closure-library/closure/css/inlay/g-ratio.css
D third_party/closure-library/closure/goog/array/array.js
D third_party/closure-library/closure/goog/array/array_test.html
D third_party/closure-library/closure/goog/asserts/asserts.js
D third_party/closure-library/closure/goog/asserts/asserts_test.html
D third_party/closure-library/closure/goog/async/conditionaldelay.js
D
third_party/closure-library/closure/goog/async/conditionaldelay_test.html
D third_party/closure-library/closure/goog/async/delay.js
D third_party/closure-library/closure/goog/async/delay_test.html
D third_party/closure-library/closure/goog/async/throttle.js
D third_party/closure-library/closure/goog/async/throttle_test.html
D third_party/closure-library/closure/goog/base.js
D third_party/closure-library/closure/goog/base_test.html
D third_party/closure-library/closure/goog/bootstrap/webworkers.js
D third_party/closure-library/closure/goog/color/alpha.js
D third_party/closure-library/closure/goog/color/alpha_test.html
D third_party/closure-library/closure/goog/color/color.js
D third_party/closure-library/closure/goog/color/color_test.html
D third_party/closure-library/closure/goog/color/names.js
D third_party/closure-library/closure/goog/crypt/arc4.js
D third_party/closure-library/closure/goog/crypt/arc4_test.html
D third_party/closure-library/closure/goog/crypt/base64.js
D third_party/closure-library/closure/goog/crypt/base64_test.html
D third_party/closure-library/closure/goog/crypt/basen.js
D third_party/closure-library/closure/goog/crypt/basen_test.html
D third_party/closure-library/closure/goog/crypt/crypt.js
D third_party/closure-library/closure/goog/crypt/crypt_perf.html
D third_party/closure-library/closure/goog/crypt/crypt_test.html
D third_party/closure-library/closure/goog/crypt/hash.js
D third_party/closure-library/closure/goog/crypt/hash32.js
D third_party/closure-library/closure/goog/crypt/hash32_test.html
D third_party/closure-library/closure/goog/crypt/hash_test.js
D third_party/closure-library/closure/goog/crypt/hmac.js
D third_party/closure-library/closure/goog/crypt/hmac_test.html
D third_party/closure-library/closure/goog/crypt/md5.js
D third_party/closure-library/closure/goog/crypt/md5_perf.html
D third_party/closure-library/closure/goog/crypt/md5_test.html
D third_party/closure-library/closure/goog/crypt/sha1.js
D third_party/closure-library/closure/goog/crypt/sha1_test.html
D third_party/closure-library/closure/goog/css/autocomplete.css
D third_party/closure-library/closure/goog/css/bubble.css
D third_party/closure-library/closure/goog/css/button.css
D third_party/closure-library/closure/goog/css/charpicker.css
D third_party/closure-library/closure/goog/css/checkbox.css
D third_party/closure-library/closure/goog/css/colormenubutton.css
D third_party/closure-library/closure/goog/css/colorpalette.css
D third_party/closure-library/closure/goog/css/colorpicker-simplegrid.css
D third_party/closure-library/closure/goog/css/combobox.css
D third_party/closure-library/closure/goog/css/common.css
D third_party/closure-library/closure/goog/css/css3button.css
D third_party/closure-library/closure/goog/css/css3menubutton.css
D third_party/closure-library/closure/goog/css/custombutton.css
D third_party/closure-library/closure/goog/css/datepicker.css
D third_party/closure-library/closure/goog/css/dialog.css
D third_party/closure-library/closure/goog/css/dimensionpicker.css
D third_party/closure-library/closure/goog/css/dragdropdetector.css
D third_party/closure-library/closure/goog/css/editor/bubble.css
D third_party/closure-library/closure/goog/css/editor/dialog.css
D third_party/closure-library/closure/goog/css/editor/linkdialog.css
D third_party/closure-library/closure/goog/css/editortoolbar.css
D third_party/closure-library/closure/goog/css/filteredmenu.css
D third_party/closure-library/closure/goog/css/filterobservingmenuitem.css
D third_party/closure-library/closure/goog/css/flatbutton.css
D third_party/closure-library/closure/goog/css/flatmenubutton.css
D third_party/closure-library/closure/goog/css/hovercard.css
D third_party/closure-library/closure/goog/css/hsvapalette.css
D third_party/closure-library/closure/goog/css/hsvpalette.css
D third_party/closure-library/closure/goog/css/imagelessbutton.css
D third_party/closure-library/closure/goog/css/imagelessmenubutton.css
D third_party/closure-library/closure/goog/css/inputdatepicker.css
D third_party/closure-library/closure/goog/css/linkbutton.css
D third_party/closure-library/closure/goog/css/menu.css
D third_party/closure-library/closure/goog/css/menubutton.css
D third_party/closure-library/closure/goog/css/menuitem.css
D third_party/closure-library/closure/goog/css/menuseparator.css
D third_party/closure-library/closure/goog/css/multitestrunner.css
D third_party/closure-library/closure/goog/css/offline.css
D third_party/closure-library/closure/goog/css/palette.css
D third_party/closure-library/closure/goog/css/popupdatepicker.css
D third_party/closure-library/closure/goog/css/roundedpanel.css
D third_party/closure-library/closure/goog/css/roundedtab.css
D third_party/closure-library/closure/goog/css/submenu.css
D third_party/closure-library/closure/goog/css/tab.css
D third_party/closure-library/closure/goog/css/tabbar.css
D third_party/closure-library/closure/goog/css/tablesorter.css
D third_party/closure-library/closure/goog/css/toolbar.css
D third_party/closure-library/closure/goog/css/tooltip.css
D third_party/closure-library/closure/goog/css/tree.css
D third_party/closure-library/closure/goog/css/tristatemenuitem.css
D third_party/closure-library/closure/goog/cssom/cssom.js
D third_party/closure-library/closure/goog/cssom/cssom_test.html
D third_party/closure-library/closure/goog/cssom/cssom_test_import_1.css
D third_party/closure-library/closure/goog/cssom/cssom_test_import_2.css
D third_party/closure-library/closure/goog/cssom/cssom_test_link_1.css
D third_party/closure-library/closure/goog/cssom/iframe/style.js
D third_party/closure-library/closure/goog/cssom/iframe/style_test.html
D
third_party/closure-library/closure/goog/cssom/iframe/style_test_import.css
D third_party/closure-library/closure/goog/datasource/datamanager.js
D third_party/closure-library/closure/goog/datasource/datasource.js
D third_party/closure-library/closure/goog/datasource/datasource_test.html
D third_party/closure-library/closure/goog/datasource/expr.js
D third_party/closure-library/closure/goog/datasource/expr_test.html
D third_party/closure-library/closure/goog/datasource/fastdatanode.js
D
third_party/closure-library/closure/goog/datasource/fastdatanode_test.html
D third_party/closure-library/closure/goog/datasource/jsdatasource.js
D third_party/closure-library/closure/goog/datasource/jsondatasource.js
D
third_party/closure-library/closure/goog/datasource/jsxmlhttpdatasource.js
D
third_party/closure-library/closure/goog/datasource/jsxmlhttpdatasource_test.html
D third_party/closure-library/closure/goog/datasource/xmldatasource.js
D third_party/closure-library/closure/goog/date/date.js
D third_party/closure-library/closure/goog/date/date_test.html
D third_party/closure-library/closure/goog/date/datelike.js
D third_party/closure-library/closure/goog/date/daterange.js
D third_party/closure-library/closure/goog/date/daterange_test.html
D third_party/closure-library/closure/goog/date/relative.js
D third_party/closure-library/closure/goog/date/relative_test.html
D third_party/closure-library/closure/goog/date/utcdatetime.js
D third_party/closure-library/closure/goog/date/utcdatetime_test.html
D third_party/closure-library/closure/goog/debug/console.js
D third_party/closure-library/closure/goog/debug/debug.js
D third_party/closure-library/closure/goog/debug/debug_test.html
D third_party/closure-library/closure/goog/debug/debugwindow.js
D third_party/closure-library/closure/goog/debug/devcss/devcss.js
D third_party/closure-library/closure/goog/debug/devcss/devcss_test.html
D third_party/closure-library/closure/goog/debug/devcss/devcssrunner.js
D third_party/closure-library/closure/goog/debug/divconsole.js
D third_party/closure-library/closure/goog/debug/enhanceerror_test.html
D third_party/closure-library/closure/goog/debug/entrypointregistry.js
D
third_party/closure-library/closure/goog/debug/entrypointregistry_test.html
D third_party/closure-library/closure/goog/debug/error.js
D third_party/closure-library/closure/goog/debug/error_test.html
D third_party/closure-library/closure/goog/debug/errorhandler.js
D
third_party/closure-library/closure/goog/debug/errorhandler_async_test.html
D third_party/closure-library/closure/goog/debug/errorhandler_test.html
D third_party/closure-library/closure/goog/debug/errorhandlerweakdep.js
D third_party/closure-library/closure/goog/debug/errorreporter.js
D third_party/closure-library/closure/goog/debug/errorreporter_test.html
D third_party/closure-library/closure/goog/debug/fancywindow.js
D third_party/closure-library/closure/goog/debug/formatter.js
D third_party/closure-library/closure/goog/debug/gcdiagnostics.js
D third_party/closure-library/closure/goog/debug/logbuffer.js
D third_party/closure-library/closure/goog/debug/logbuffer_test.html
D third_party/closure-library/closure/goog/debug/logger.js
D third_party/closure-library/closure/goog/debug/logger_test.html
D third_party/closure-library/closure/goog/debug/logrecord.js
D third_party/closure-library/closure/goog/debug/reflect.js
D third_party/closure-library/closure/goog/debug/reflect_test.html
D third_party/closure-library/closure/goog/debug/relativetimeprovider.js
D third_party/closure-library/closure/goog/debug/tracer.js
D third_party/closure-library/closure/goog/debug/tracer_test.html
D third_party/closure-library/closure/goog/demos/advancedtooltip.html
D third_party/closure-library/closure/goog/demos/animationqueue.html
D third_party/closure-library/closure/goog/demos/autocomplete-basic.html
D third_party/closure-library/closure/goog/demos/autocompleteremote.html
D third_party/closure-library/closure/goog/demos/autocompleteremotedata.js
D
third_party/closure-library/closure/goog/demos/autocompleterichremote.html
D
third_party/closure-library/closure/goog/demos/autocompleterichremotedata.js
D third_party/closure-library/closure/goog/demos/bidiinput.html
D third_party/closure-library/closure/goog/demos/bubble.html
D third_party/closure-library/closure/goog/demos/button.html
D third_party/closure-library/closure/goog/demos/charcounter.html
D third_party/closure-library/closure/goog/demos/charpicker.html
D third_party/closure-library/closure/goog/demos/checkbox.html
D third_party/closure-library/closure/goog/demos/color-contrast.html
D third_party/closure-library/closure/goog/demos/colormenubutton.html
D third_party/closure-library/closure/goog/demos/colorpicker.html
D third_party/closure-library/closure/goog/demos/combobox.html
D third_party/closure-library/closure/goog/demos/container.html
D third_party/closure-library/closure/goog/demos/control.html
D third_party/closure-library/closure/goog/demos/css/demo.css
D third_party/closure-library/closure/goog/demos/css/emojipicker.css
D third_party/closure-library/closure/goog/demos/css/emojisprite.css
D third_party/closure-library/closure/goog/demos/css3button.html
D third_party/closure-library/closure/goog/demos/css3menubutton.html
D third_party/closure-library/closure/goog/demos/cssspriteanimation.html
[[ 1304 additional files ]]

[a...@chromium.org]

Committed patchset #1 manually as r1c6776c (presubmit successful).

https://codereview.appspot.com/7972044/

[usrb...@yahoo.com]

On 2013/03/22 16:34:05, arv-chromium wrote:
> This deletes thousands of files from our repo =D

I think you almost broke rietveld with this patch! Kept getting internal
server errors for awhile there.

Just to note, the html tests don't work live from the site anymore. I
don't really think that's a big deal, though. Would be nice to lose the
closure library dependency eventually, though. I do like the fact that
the repo history is no longer in danger of being spammed for every
closure update. LGTM.

And out of curiosity, what's the official way to automatically install
all the dependencies to the local 'node_modules' folder of the working
tree? I ended up just

# I have something like 8 working trees via git-new-workdir, so being
# able to symlink is nice (for auto-sync; disk space is cheap).
npm install -g closure-library
for d in traceur-compiler.*; do
cd $d
npm link closure-library
cd ..
done

but this means I have to check package.json for updates. Theoretical,
because package.json's devDependencies isn't likely to undergo constant
churn. But just for future reference.


https://codereview.appspot.com/7972044/

[Erik Arvidsson]

If you do not care about size on disk "npm install" is the way to go.
It will pull down all the dependencies for you

--
erik

[usrb...@yahoo.com]

On 2013/03/22 20:24:37, arv-chromium wrote:
> If you do not care about size on disk "npm install" is the way to go.
> It will pull down all the dependencies for you

Thanks. I actually didn't consider that (not very fluent with npm). I'll
probably just 'npm install' to one worktree and link that 'node_modules'
to all of them.


https://codereview.appspot.com/7972044/