Groups

Traceur Compiler Reviews

1–30 of 283

0 selected

johnj...@chromium.org2

10/28/13

Update source-map devDependencies to 0.1.30 (issue 18500043)

On 2013/10/28 17:33:43, johnjbarton wrote: > ready for review oh sorry, I submitted pull requests

unread,

Update source-map devDependencies to 0.1.30 (issue 18500043)

On 2013/10/28 17:33:43, johnjbarton wrote: > ready for review oh sorry, I submitted pull requests

10/28/13

usrb...@yahoo.com

4/6/13

Re: Handle '//:lint' and '//:nolint' comments. (issue 7801048)

Thanks for the commit. I promise, you'll love traceur's regained semicolon-checking powers so

unread,

Re: Handle '//:lint' and '//:nolint' comments. (issue 7801048)

Thanks for the commit. I promise, you'll love traceur's regained semicolon-checking powers so

4/6/13

usrb...@yahoo.com, a...@chromium.org8

4/5/13

Handle '//:lint' and '//:nolint' comments. (issue 7801048)

Committed as f8914ea2fe3287840c6770a900bfbe5ffea7d9dd https://codereview.appspot.com/7801048/

unread,

Handle '//:lint' and '//:nolint' comments. (issue 7801048)

Committed as f8914ea2fe3287840c6770a900bfbe5ffea7d9dd https://codereview.appspot.com/7801048/

4/5/13

usrb...@yahoo.com, a...@chromium.org2

4/2/13

Re: Fix setting of StopIteration and GeneratorReturn. (issue 7757044)

LGTM Committed as 3758de5d46486130dd733f14fb6a01a65329ca24 https://codereview.appspot.com/7757044/

unread,

Re: Fix setting of StopIteration and GeneratorReturn. (issue 7757044)

LGTM Committed as 3758de5d46486130dd733f14fb6a01a65329ca24 https://codereview.appspot.com/7757044/

4/2/13

usrb...@yahoo.com, a...@chromium.org2

4/2/13

Re: Add isStopIteration to '@iter' module. Update the tests to use it. (issue 7610045)

LGTM Committed as eb43f08a1c9ef51295a166e21a8f76704b7e3be0 https://codereview.appspot.com/7610045/

unread,

Re: Add isStopIteration to '@iter' module. Update the tests to use it. (issue 7610045)

LGTM Committed as eb43f08a1c9ef51295a166e21a8f76704b7e3be0 https://codereview.appspot.com/7610045/

4/2/13

usrb...@yahoo.com, a...@chromium.org2

4/2/13

Re: demo/repl.html: Add the ability to show the full options list. (one-click god-mode for the peons?) (issue 7329050)

Lets leave the checkbox for now https://codereview.appspot.com/7329050/

unread,

Re: demo/repl.html: Add the ability to show the full options list. (one-click god-mode for the peons?) (issue 7329050)

Lets leave the checkbox for now https://codereview.appspot.com/7329050/

4/2/13

pe...@peterhallam.com, a...@chromium.org2

4/2/13

Fix reading files on windows. (issue 8238043)

LGTM Do you mind sending a pull request on github instead? https://codereview.appspot.com/8238043/

unread,

Fix reading files on windows. (issue 8238043)

LGTM Do you mind sending a pull request on github instead? https://codereview.appspot.com/8238043/

4/2/13

usrb...@yahoo.com, Erik Arvidsson9

3/29/13

Re: Make 'traceur' cleanup process.argv and setup the node.js module so that relative require works. (issue 7552046)

Congratulations from me too. There are a lot of kinks to work out to make Traceur go from a research

unread,

Re: Make 'traceur' cleanup process.argv and setup the node.js module so that relative require works. (issue 7552046)

Congratulations from me too. There are a lot of kinks to work out to make Traceur go from a research

3/29/13

a...@chromium.org

3/27/13

Re: Add parse tree writer round trip testing to feature tests. (issue 7832045)

LGTM I can merge this to GitHub if you want to commit this to Google Code. https://codereview.appspot

unread,

Re: Add parse tree writer round trip testing to feature tests. (issue 7832045)

LGTM I can merge this to GitHub if you want to commit this to Google Code. https://codereview.appspot

3/27/13

a...@chromium.org, usrb...@yahoo.com3

3/27/13

Make 'traceur' cleanup process.argv and setup the node.js module so that relative require works. (issue 7552046)

Note: I'm mostly playing the role of opinionated observer here. arv is the main reviewer here.

unread,

Make 'traceur' cleanup process.argv and setup the node.js module so that relative require works. (issue 7552046)

Note: I'm mostly playing the role of opinionated observer here. arv is the main reviewer here.

3/27/13

a...@chromium.org, usrb...@yahoo.com4

3/26/13

Re: Move util functions from DefaultParametersTransformer.js to src/semantics/util.js (issue 7509043)

> At one point I hacked up a version of free variable checker that took > a list of free

unread,

Re: Move util functions from DefaultParametersTransformer.js to src/semantics/util.js (issue 7509043)

> At one point I hacked up a version of free variable checker that took > a list of free

3/26/13

a...@chromium.org, usrb...@yahoo.com7

3/25/13

Add .npmignore file (issue 7531049)

> Don't you mean the other way around? .gitignore should be ignored by > .npmignore. I

unread,

Add .npmignore file (issue 7531049)

> Don't you mean the other way around? .gitignore should be ignored by > .npmignore. I

3/25/13

usrb...@yahoo.com, a...@chromium.org2

3/25/13

Makefile: run 'npm install' whenever 'package.json' is updated. (issue 7681046)

LGTM Committed as 636ed7a8fef2c25e11e72f8b0554afa7da89256f https://codereview.appspot.com/7681046/

unread,

Makefile: run 'npm install' whenever 'package.json' is updated. (issue 7681046)

LGTM Committed as 636ed7a8fef2c25e11e72f8b0554afa7da89256f https://codereview.appspot.com/7681046/

3/25/13

usrb...@yahoo.com, Erik Arvidsson7

3/25/13

Wrap the newest version of 'source-map'. (issue 7789051)

My personal preference is 80 or 100 line length but allow exceptions. The problem with exceptions is

unread,

Wrap the newest version of 'source-map'. (issue 7789051)

My personal preference is 80 or 100 line length but allow exceptions. The problem with exceptions is

3/25/13

usrb...@yahoo.com, a...@chromium.org3

3/25/13

Optimization: Remove empty FallthroughState states. (issue 7541050)

https://codereview.appspot.com/7541050/diff/1/src/codegeneration/generator/CPSTransformer.js File src

unread,

Optimization: Remove empty FallthroughState states. (issue 7541050)

https://codereview.appspot.com/7541050/diff/1/src/codegeneration/generator/CPSTransformer.js File src

3/25/13

usrb...@yahoo.com, a...@chromium.org6

3/25/13

Don't check 'with' for undefined vars, but do record var declarations. (issue 7577048)

https://codereview.appspot.com/7577048/diff/12001/test/feature/FreeVariableChecker/WithVarDecl.js

unread,

Don't check 'with' for undefined vars, but do record var declarations. (issue 7577048)

https://codereview.appspot.com/7577048/diff/12001/test/feature/FreeVariableChecker/WithVarDecl.js

3/25/13

usrb...@yahoo.com, a...@chromium.org2

3/24/13

Optimization: Don't transform plain 'break' in 'switch' to a state machine. (issue 7865048)

LGTM Committed as 0d4c5edb5b9388f60db3a31ea2bf471b58990afa https://codereview.appspot.com/7865048/

unread,

Optimization: Don't transform plain 'break' in 'switch' to a state machine. (issue 7865048)

LGTM Committed as 0d4c5edb5b9388f60db3a31ea2bf471b58990afa https://codereview.appspot.com/7865048/

3/24/13

a...@chromium.org

3/24/13

Fix issue 223, CloneTreeTransformation fails on trees with empty lists Add transformList() and retu… (issue 7802046)

https://codereview.appspot.com/7802046/diff/1/src/codegeneration/CloneTreeTransformer.js File src/

unread,

Fix issue 223, CloneTreeTransformation fails on trees with empty lists Add transformList() and retu… (issue 7802046)

https://codereview.appspot.com/7802046/diff/1/src/codegeneration/CloneTreeTransformer.js File src/

3/24/13

a...@chromium.org, usrb...@yahoo.com5

3/22/13

Use npm package for closure-library (issue 7972044)

On 2013/03/22 20:24:37, arv-chromium wrote: > If you do not care about size on disk "npm

unread,

Use npm package for closure-library (issue 7972044)

On 2013/03/22 20:24:37, arv-chromium wrote: > If you do not care about size on disk "npm

3/22/13

a...@chromium.org2

3/22/13

Fix issue with npm package.js (issue 7849048)

Committed patchset #1 manually as r74e5bd0 (presubmit successful). https://codereview.appspot.com/

unread,

Fix issue with npm package.js (issue 7849048)

Committed patchset #1 manually as r74e5bd0 (presubmit successful). https://codereview.appspot.com/

3/22/13

usrb...@yahoo.com, a...@chromium.org4

3/21/13

Code cleanup: break or shorten long lines, misc cleanup. (issue 7686047)

LGTM Committed as a51e03ddfbcc2caa114d932e40b43aa22fda960e https://codereview.appspot.com/7686047/

unread,

Code cleanup: break or shorten long lines, misc cleanup. (issue 7686047)

LGTM Committed as a51e03ddfbcc2caa114d932e40b43aa22fda960e https://codereview.appspot.com/7686047/

3/21/13

usrb...@yahoo.com, a...@chromium.org3

3/21/13

PlaceholderParser: handle arrays of statements, expressions, etc. (issue 7649045)

Committed as bbe258db9a5e993d33732cbf328b17a9b38e4240 https://codereview.appspot.com/7649045/

unread,

PlaceholderParser: handle arrays of statements, expressions, etc. (issue 7649045)

Committed as bbe258db9a5e993d33732cbf328b17a9b38e4240 https://codereview.appspot.com/7649045/

3/21/13

usrb...@yahoo.com, a...@chromium.org2

3/21/13

Make 'traceur' ignore shebang lines in files. (issue 7945043)

LGTM FYI, if you "npm install -g" you can do #!/usr/bin/env traceur https://codereview.

unread,

Make 'traceur' ignore shebang lines in files. (issue 7945043)

LGTM FYI, if you "npm install -g" you can do #!/usr/bin/env traceur https://codereview.

3/21/13

a...@chromium.org4

3/20/13

Reduce code duplication due to FunctionDeclaration and FunctionExpression (issue 7693051)

Committed patchset #3 manually as r6040890 (presubmit successful). https://codereview.appspot.com/

unread,

Reduce code duplication due to FunctionDeclaration and FunctionExpression (issue 7693051)

Committed patchset #3 manually as r6040890 (presubmit successful). https://codereview.appspot.com/

3/20/13

usrb...@yahoo.com, a...@chromium.org5

3/19/13

Optimization: Move the main state machine code into a separate function. (issue 7759049)

LGTM Committed as 61695efebd562b7ceafc9a20c3f380c5666d4fc8 https://codereview.appspot.com/7759049/

unread,

Optimization: Move the main state machine code into a separate function. (issue 7759049)

LGTM Committed as 61695efebd562b7ceafc9a20c3f380c5666d4fc8 https://codereview.appspot.com/7759049/

3/19/13

a...@chromium.org, usrb...@yahoo.com3

3/18/13

Re: Command line traceur will now invoke the interpreter if no out param is passed (issue 7810043)

Committed patchset #6 manually as rfa7c011 (presubmit successful). https://codereview.appspot.com/

unread,

Re: Command line traceur will now invoke the interpreter if no out param is passed (issue 7810043)

Committed patchset #6 manually as rfa7c011 (presubmit successful). https://codereview.appspot.com/

3/18/13

usrb...@yahoo.com, Erik Arvidsson4

3/18/13

Re: Use RuntimeInliner to provide the generator common code. (re-remove TODOs) (issue 7487046)

Submitted all the patches without any merge conflicts and all tests still passes. Thanks Peter was

unread,

Re: Use RuntimeInliner to provide the generator common code. (re-remove TODOs) (issue 7487046)

Submitted all the patches without any merge conflicts and all tests still passes. Thanks Peter was

3/18/13

usrb...@yahoo.com, a...@chromium.org2

3/17/13

Re: Use RuntimeInliner to provide the generator common code. (re-remove TODOs) (issue 7487046)

LGTM https://codereview.appspot.com/7487046/diff/10002/src/codegeneration/generator/

unread,

Re: Use RuntimeInliner to provide the generator common code. (re-remove TODOs) (issue 7487046)

LGTM https://codereview.appspot.com/7487046/diff/10002/src/codegeneration/generator/

3/17/13

a...@chromium.org, usrb...@yahoo.com2

3/15/13

Command line traceur will now invoke the interpreter if no out param is passed (issue 7810043)

Mostly looks okay. The only issues are with the arg handling and needing the 'require' to

unread,

Command line traceur will now invoke the interpreter if no out param is passed (issue 7810043)

Mostly looks okay. The only issues are with the arg handling and needing the 'require' to

3/15/13

a...@chromium.org, usrb...@yahoo.com4

3/14/13

Use an inner object instead of captured vars. (issue 7547045)

Seems like all of them are LGTM'ed now... I'll try to commit them https://codereview.appspot.

unread,

Use an inner object instead of captured vars. (issue 7547045)

Seems like all of them are LGTM'ed now... I'll try to commit them https://codereview.appspot.

3/14/13

Search

Clear search

Close search

Google apps

Main menu