patch to run IncludeMacro with Trac 1.6

9 views
Skip to first unread message

Ales Horak

unread,
Sep 13, 2025, 12:13:21 PM (5 days ago) Sep 13
to Trac Users
current https://trac-hacks.org/wiki/IncludeMacro does not run under Trac 1.6
due to genshi imports

see the attached patch to make it functional

-- 
ales horak

macros.py.patch

Jun Omae

unread,
Sep 13, 2025, 11:53:04 PM (5 days ago) Sep 13
to trac-...@googlegroups.com
Hi,
Thanks for the patch! However, it seems to be incomplete.

$ pyflakes includemacro/macros.py
includemacro/macros.py:214:59: undefined name 'TracHTMLSanitizer'
includemacro/macros.py:244:23: undefined name 'ParseError'
includemacro/macros.py:255:27: undefined name 'ParseError'
includemacro/macros.py:288:20: undefined name 'ParseError'

Could you please try the attached patch?
includemacro-remove-uses-of-genshi.diff

Aleš Horák

unread,
Sep 14, 2025, 10:30:50 PM (4 days ago) Sep 14
to trac-...@googlegroups.com
Hi,

thank you. my patch was the minimum to get it to work, just fixing the errors that appeared :-)

yours is more complete and functional 👍

--
ales horak


--
Aleš Horák


ne 14. 9. 2025 v 5:53 odesílatel Jun Omae <jun...@gmail.com> napsal:
--
You received this message because you are subscribed to a topic in the Google Groups "Trac Users" group.
To unsubscribe from this topic, visit https://groups.google.com/d/topic/trac-users/oIX9bq6TkVc/unsubscribe.
To unsubscribe from this group and all its topics, send an email to trac-users+...@googlegroups.com.
To view this discussion visit https://groups.google.com/d/msgid/trac-users/aMY8Eia7Pi0d/sOV%40localhost.

Jun Omae

unread,
Sep 16, 2025, 10:13:15 PM (2 days ago) Sep 16
to trac-...@googlegroups.com
Thanks for the feedback.
I've committed the patch in [18706].
You received this message because you are subscribed to the Google Groups "Trac Users" group.
To unsubscribe from this group and stop receiving emails from it, send an email to trac-users+...@googlegroups.com.
To view this discussion visit https://groups.google.com/d/msgid/trac-users/CAHm62qP8EwaOVoCpjNiTBThhNNLAs6%2BGGrU6nznXEoX6AOPw7A%40mail.gmail.com.


-- 
Jun Omae <jun...@gmail.com> (大前 潤)
Reply all
Reply to author
Forward
0 new messages