timeline provider

0 views
Skip to first unread message

Ian Jones

unread,
May 29, 2008, 6:04:25 PM5/29/08
to trac-peerreview-dev
I don't see code reviews in the timeline. Did I miss something during
install or is this a feature in need of request/development?

bse...@plus.net

unread,
May 30, 2008, 3:24:15 AM5/30/08
to trac-peerreview-dev
This is something that needs development work from the knowledge I
have. I think this is actually a crucial part of the plugin, for
visibility reasons. You can raise a request for this, and hopefully it
can be scheduled in at some point, as it is something that I would
like as well.

bse...@plus.net

unread,
May 30, 2008, 6:52:52 AM5/30/08
to trac-peerreview-dev
Hi Ian

Just to further this from this Morning, Seb has looked into this, and
currently he has it so we can turn the Code Review Timeline on or off.
All that is needed now is to actually implement what we want to go
into the Time Line, so hopefully we can get this working soon in the
toddler version of the plugin.

We have just had a discussion, and one of the things we may want to do
is use the Ticket infrastructure that is already there and use that as
the main area to hold code reviews. This would then also automatically
link into the timeline.

Anway for now, we simply want to get the time line aspect up and
running.

Ian Jones

unread,
May 30, 2008, 11:39:51 AM5/30/08
to trac-peer...@googlegroups.com
Great news. I also started to look at implementing it against the
toddler branch last night. Sounds like Seb and myself are in about the
same spot. I've got a working timeline filter. I'm new to developing
plugins for trac but if you need any help let me know.

Ian

Sebastian Marek

unread,
May 30, 2008, 5:01:12 PM5/30/08
to trac-peer...@googlegroups.com
Hi Ian,


On Fri, May 30, 2008 at 4:39 PM, Ian Jones <shr...@gmail.com> wrote:

Great news. I also started to look at implementing it against the
toddler branch last night. Sounds like Seb and myself are in about the
same spot. I've got a working timeline filter. I'm new to developing
plugins for trac but if you need any help let me know.

Ian

In intrigued me so much that I've actually added support for it in 2.1-toddler. It seems to be quite stable, but I haven't tested it too much. Support is pretty basic, mainly because of poor plugin backend. All that we can get out of it is when the code review was raised, by who, and display some additional details; notes, reviewers and linking it with the original review.

Unfortunately there is no history of changes made to a code review so we can't fully track its lifetime. But that's gonna change for sure in version 3.0.

I hope that's something for a start.

--
Sebastian Marek

Ian Jones

unread,
May 30, 2008, 5:21:40 PM5/30/08
to trac-peer...@googlegroups.com
Sweet, thank you I'll be sure to play with it tonight.
Reply all
Reply to author
Forward
0 new messages