Req Code Review for Workflow plugin patch that sets ticket field to SQL

[Jim Harkins]

I’m hoping to get some feedback, a code review would be great. My patch contains only 63 lines of code.

 

Last week, over at trac-hacks.org, I posted a patch to the Advanced Ticket Workflow Plugin that adds the ability to set a field to the result of a given SQL query. This adds support in trac.ini for:

 

unresolve = resolved -> assigned

unresolve.operations = del_resolution,set_field_to_sql

unresolve.set_field_owner = SELECT author FROM ticket_change

    WHERE ticket=% (id)s AND

        field='status' AND

        newvalue = 'resolved'

    ORDER BY -time

unresolve.permissions = TICKET_MODIFY

 

Here the owner field is set to the last resolver.

 

Any ticket field including custom fields can be set to the results of any SQL Query.

 

Here’s a link to the ticket which includes the patch and documentation:

 

http://trac-hacks.org/ticket/6801

 

I welcome any feedback.

 

Thanks,

 

Jim