Ditching WebAdmin 0.10 plugin compatibility in 0.12

1 view
Skip to first unread message

Christian Boos

unread,
Oct 6, 2009, 4:05:32 AM10/6/09
to Trac Development
Hello,

While working on Environment.component_activated, I saw this code:

# Disable the pre-0.11 WebAdmin plugin
# Please note that there's no recommendation to
uninstall the
# plugin because doing so would obviously break the
backwards
# compatibility that the new integration administration
# interface tries to provide for old WebAdmin extensions
if component_name.startswith('webadmin.'):
self.log.info('The legacy TracWebAdmin plugin has been '
'automatically disabled, and the
integrated '
'administration interface will be used '
'instead.')
return False

I'd like to get rid of the compatibility code mentioned in the comment
(IAdminPageProvider in trac/admin/web_ui.py), *and* recommend to
uninstall the WebAdmin plugin.

Would everyone be OK with that?

Likewise, I think we could start to deprecate the Clearsilver support,
and remove it in 0.13 (or even earlier if nobody complains).

-- Christian

Remy Blank

unread,
Oct 6, 2009, 4:15:44 AM10/6/09
to trac...@googlegroups.com
Christian Boos wrote:
> I'd like to get rid of the compatibility code mentioned in the comment
> (IAdminPageProvider in trac/admin/web_ui.py), *and* recommend to
> uninstall the WebAdmin plugin.

+1

> Likewise, I think we could start to deprecate the Clearsilver support,
> and remove it in 0.13 (or even earlier if nobody complains).

Never used that thing, so +1 as well.

-- Remy

signature.asc

Michael Renzmann

unread,
Oct 6, 2009, 7:49:23 AM10/6/09
to trac...@googlegroups.com
Hi.

> I'd like to get rid of the compatibility code mentioned in the comment
> (IAdminPageProvider in trac/admin/web_ui.py), *and* recommend to
> uninstall the WebAdmin plugin.

+1

> Likewise, I think we could start to deprecate the Clearsilver support,
> and remove it in 0.13

+1

> (or even earlier if nobody complains).

There are enough plugins that have not yet been ported to Genshi. Thus
there should be an official grace period before Clearsilver support gets
dropped, so I'd be in favour of "deprecate in 0.12, drop in 0.13".

Bye, Mike

Jeff Hammel

unread,
Oct 6, 2009, 9:42:21 AM10/6/09
to trac...@googlegroups.com

I'll almost always choose keeping the code clean over sustaining backwards compatability, so +1 to both.

Jeff

Reply all
Reply to author
Forward
0 new messages