Why the big indent in embedded.css?

[Mark Wood]

ul.metrics {
    margin-left: 365px;
}

Why?  There's nothing to the left of the list.  It looks like a leftover after extraction from some other environment.

When embedding this in the DSpace Mirage theme (which for some reason has an absolute width), the list gets crowded up against the right edge of a surrounding box and wraps, which doesn't turn out well.  I disabled this one rule (using Firebug) and the list laid out nicely as I would have expected to see it.

I think that the surrounding matter should be responsible for positioning embeds, and the embed should just fill the box it's given.

[Heather Piwowar]

Mark, 

Good point.  You're right, it is a left over from other code, we should remove the big indent.  Jason or I will fix it soon.

(Sorry I'm not being very quick to respond and address suggestions at the moment... I'm in the midst of wrapping up other work so that I can do total-impact full time starting August 1st!)

Heather

[Mark Wood]

Ah, well, we all have Stuff We Have To Do.  Thanks for confirming my diagnosis.  I've gone ahead and edited my Github clone and sent a pull request encompassing this and some other changes I'm suggesting.

[Jason Priem]

Looked over your commits...awesome work! Thanks.

Also: let me share that it is almost midnight on a Friday, I slept two hours last night, and I am SO EXCITED to be working on total-impact right now. Seeing the community pushing changes and making the code better like this turns out to be a pretty epic motivator :)

j

On Fri, Jul 20, 2012 at 3:01 PM, Mark Wood <mw...@iupui.edu> wrote:

Ah, well, we all have Stuff We Have To Do.  Thanks for confirming my diagnosis.  I've gone ahead and edited my Github clone and sent a pull request encompassing this and some other changes I'm suggesting.

--
Jason Priem
UNC Royster Scholar
School of Information and Library Science
University of North Carolina at Chapel Hill