Tortoise SVN crash when showing the SSL certificate prompt on Windows 7

141 views
Skip to first unread message

Franck Pascutti

unread,
Dec 6, 2011, 5:46:19 AM12/6/11
to us...@tortoisesvn.tigris.org
I just installed Tortoise SVN 7.2 x64 on my Windows 7 machine. I have a systematic crash when commiting when TortoiseProc tries to prompt me for certificate information.

To reproduce the issue :
1. Setup a SVN server with SSL encryption using a non-recognized certificate,
2. Use TortoiseSVN on a Windows 7 machine to connect to this server,
3. The crash should occur.

The crash occurs in the following function:
TortoiseProc.exe!SVNPrompt::sslserverprompt(svn_auth_cred_ssl_server_trust_t * * cred_p, void * baton, const char * realm, unsigned int failures, const svn_auth_ssl_server_cert_info_t * cert_info, int may_save, apr_pool_t * pool) Line 279 C++

The cause seems to be that Tortoise SVN sets the default command control of the TaskDialog to "IDCUSTOM3" even though only "IDCUSTOM1" and "IDCUSTOM2" were added to the TaskDialog.

See the source code at:
http://code.google.com/p/tortoisesvn/source/browse/trunk/src/SVN/SVNPrompt.cpp#sl_svn22343_278

------------------------------------------------------
http://tortoisesvn.tigris.org/ds/viewMessage.do?dsForumId=4061&dsMessageId=2890898

To unsubscribe from this discussion, e-mail: [users-un...@tortoisesvn.tigris.org].

Franck Pascutti

unread,
Dec 6, 2011, 10:19:43 AM12/6/11
to us...@tortoisesvn.tigris.org
I guess this is related to this other issue: http://tortoisesvn.tigris.org/ds/viewMessage.do?dsForumId=4061&dsMessageId=2890925

Apart from the workaround listed there (using the command-line tool and downgrading), it is possible to make it work by copying a file from another computer where the certificate was permanently accepted.
The file is located into the "%APPDATA%\Subversion\auth\svn.ssl.server\" directory. You will need to get it from another computer and copy it locally.

This workaround is similar to the one using the command-line tool in that it works by making the certificate accepted (thus the buggy TaskDialog UI is not displayed).

------------------------------------------------------
http://tortoisesvn.tigris.org/ds/viewMessage.do?dsForumId=4061&dsMessageId=2890959

Stefan Küng

unread,
Dec 6, 2011, 12:52:42 PM12/6/11
to us...@tortoisesvn.tigris.org
On 06.12.2011 11:46, Franck Pascutti wrote:
> I just installed Tortoise SVN 7.2 x64 on my Windows 7 machine. I have a systematic crash when commiting when TortoiseProc tries to prompt me for certificate information.
>
> To reproduce the issue :
> 1. Setup a SVN server with SSL encryption using a non-recognized certificate,
> 2. Use TortoiseSVN on a Windows 7 machine to connect to this server,
> 3. The crash should occur.
>
> The crash occurs in the following function:
> TortoiseProc.exe!SVNPrompt::sslserverprompt(svn_auth_cred_ssl_server_trust_t * * cred_p, void * baton, const char * realm, unsigned int failures, const svn_auth_ssl_server_cert_info_t * cert_info, int may_save, apr_pool_t * pool) Line 279 C++
>
> The cause seems to be that Tortoise SVN sets the default command control of the TaskDialog to "IDCUSTOM3" even though only "IDCUSTOM1" and "IDCUSTOM2" were added to the TaskDialog.
>
> See the source code at:
> http://code.google.com/p/tortoisesvn/source/browse/trunk/src/SVN/SVNPrompt.cpp#sl_svn22343_278


Opened issue #155 for this:
http://code.google.com/p/tortoisesvn/issues/detail?id=155

Stefan

--
___
oo // \\ "De Chelonian Mobile"
(_,\/ \_/ \ TortoiseSVN
\ \_/_\_/> The coolest Interface to (Sub)Version Control
/_/ \_\ http://tortoisesvn.net

------------------------------------------------------
http://tortoisesvn.tigris.org/ds/viewMessage.do?dsForumId=4061&dsMessageId=2890995

Reply all
Reply to author
Forward
0 new messages