Escape key closes commit dialog
59 views
Skip to first unread message
Jason Chown
Nov 28, 2014, 10:48:16 AM11/28/14
to us...@tortoisesvn.tigris.org
Hi,
It might be just me, but I often lose my partial commit: I'll carefully
select the files I want (reviewing the changes in each) and finally
start typing the commit message. Oh - I have a typo, let's just change
that. My muscle memory instantly hits escape to revert the selection
(which works on Windows in most forms, browser address bars etc.), but
no, the commit dialog is closed without verification! I don't think
Escape has closed dialogs in most software since the late 80s...
Can it at least offer an "abandon commit? OK/Cancel?" I hit the
table-flipping state at least twice a week as it stands...
Jason Chown
------------------------------------------------------
http://tortoisesvn.tigris.org/ds/viewMessage.do?dsForumId=4061&dsMessageId=3091960
To unsubscribe from this discussion, e-mail: [users-un...@tortoisesvn.tigris.org].
It might be just me, but I often lose my partial commit: I'll carefully
select the files I want (reviewing the changes in each) and finally
start typing the commit message. Oh - I have a typo, let's just change
that. My muscle memory instantly hits escape to revert the selection
(which works on Windows in most forms, browser address bars etc.), but
no, the commit dialog is closed without verification! I don't think
Escape has closed dialogs in most software since the late 80s...
Can it at least offer an "abandon commit? OK/Cancel?" I hit the
table-flipping state at least twice a week as it stands...
Jason Chown
------------------------------------------------------
http://tortoisesvn.tigris.org/ds/viewMessage.do?dsForumId=4061&dsMessageId=3091960
To unsubscribe from this discussion, e-mail: [users-un...@tortoisesvn.tigris.org].
Stefan Küng
Nov 28, 2014, 10:52:56 AM11/28/14
to us...@tortoisesvn.tigris.org
On 28.11.2014 16:47, Jason Chown wrote:
> Hi,
>
> It might be just me, but I often lose my partial commit: I'll carefully
> select the files I want (reviewing the changes in each) and finally
> start typing the commit message. Oh - I have a typo, let's just change
> that. My muscle memory instantly hits escape to revert the selection
> (which works on Windows in most forms, browser address bars etc.), but
> no, the commit dialog is closed without verification! I don't think
> Escape has closed dialogs in most software since the late 80s...
>
> Can it at least offer an "abandon commit? OK/Cancel?" I hit the
> table-flipping state at least twice a week as it stands...
First: pressing escape always closes dialogs. Even today. It doesn't
> Hi,
>
> It might be just me, but I often lose my partial commit: I'll carefully
> select the files I want (reviewing the changes in each) and finally
> start typing the commit message. Oh - I have a typo, let's just change
> that. My muscle memory instantly hits escape to revert the selection
> (which works on Windows in most forms, browser address bars etc.), but
> no, the commit dialog is closed without verification! I don't think
> Escape has closed dialogs in most software since the late 80s...
>
> Can it at least offer an "abandon commit? OK/Cancel?" I hit the
> table-flipping state at least twice a week as it stands...
close main windows but it always closes dialogs. And the commit dialog
is as the name says a dialog.
Second: While you want the escape key to NOT close the dialog, others
want the escape key to close any TSVN dialog immediately without any
confirmation or anything else even if it would mean getting corrupted
working copies:
http://tortoisesvn.tigris.org/ds/viewMessage.do?dsForumId=4061&dsMessageId=3091897
So the behavior as it is now will stay for now. Sorry - can't do it
right for everyone.
Stefan
--
___
oo // \\ "De Chelonian Mobile"
(_,\/ \_/ \ TortoiseSVN
\ \_/_\_/> The coolest interface to (Sub)version control
/_/ \_\ http://tortoisesvn.net
------------------------------------------------------
http://tortoisesvn.tigris.org/ds/viewMessage.do?dsForumId=4061&dsMessageId=3091961
Kerry, Richard
Nov 28, 2014, 11:47:58 AM11/28/14
to us...@tortoisesvn.tigris.org
In TortoiseCVS if you hit Escape and you have already entered anything in the Log Message field, it shows a dialog asking something like "Do you want to discard this Log Message ?" before closing the dialog. (If it is blank Escape will close the dialog unconditionally)
Perhaps it could be done like that. Perhaps with a configuration setting like "do you want to be prompted about losing partially completed log messages on selecting escape from the Commit dialog" so that those that want strict instant escapes at all times can get that.
Possibly,
Richard.
Richard Kerry
BNCS Engineer, SI SOL Telco & Media Vertical Practice
G300, Stadium House, Wood Lane, London, W12 7TA
This e-mail and the documents attached are confidential and intended solely for the addressee; it may also be privileged. If you receive this e-mail in error, please notify the sender immediately and destroy it. As its integrity cannot be secured on the Internet, the Atos group liability cannot be triggered for the message content. Although the sender endeavours to maintain a computer virus-free network, the sender does not warrant that this transmission is virus-free and will not be liable for any damages resulting from any virus transmitt
From: Stefan Küng [torto...@gmail.com]
Sent: 28 November 2014 15:52
To: us...@tortoisesvn.tigris.org
Subject: Re: Escape key closes commit dialog
Sent: 28 November 2014 15:52
To: us...@tortoisesvn.tigris.org
Subject: Re: Escape key closes commit dialog
Atos, Atos Consulting, Worldline and Canopy The Open Cloud Company are trading names used by the Atos group. The following trading entities are registered in England and Wales: Atos IT Services UK Limited (registered number 01245534), Atos Consulting Limited
(registered number 04312380), Atos Worldline UK Limited (registered number 08514184) and Canopy The Open Cloud Company Limited (registration number 08011902). The registered office for each is at 4 Triton Square, Regent’s Place, London, NW1 3HG.The VAT No.
for each is: GB232327983.
This e-mail and the documents attached are confidential and intended solely for the addressee, and may contain confidential or privileged information. If you receive this e-mail in error, you are not authorised to copy, disclose, use or retain it. Please notify the sender immediately and delete this email from your systems. As emails may be intercepted, amended or lost, they are not secure. Atos therefore can accept no liability for any errors or their content. Although Atos endeavours to maintain a virus-free network, we do not warrant that this transmission is virus-free and can accept no liability for any damages resulting from any virus transmitted. The risks are deemed to be accepted by everyone who communicates with Atos by email.
This e-mail and the documents attached are confidential and intended solely for the addressee, and may contain confidential or privileged information. If you receive this e-mail in error, you are not authorised to copy, disclose, use or retain it. Please notify the sender immediately and delete this email from your systems. As emails may be intercepted, amended or lost, they are not secure. Atos therefore can accept no liability for any errors or their content. Although Atos endeavours to maintain a virus-free network, we do not warrant that this transmission is virus-free and can accept no liability for any damages resulting from any virus transmitted. The risks are deemed to be accepted by everyone who communicates with Atos by email.
Simon Large
Nov 28, 2014, 11:51:44 AM11/28/14
to us...@tortoisesvn.tigris.org
On 28 November 2014 at 16:47, Kerry, Richard <richar...@atos.net> wrote:
> In TortoiseCVS if you hit Escape and you have already entered anything in the Log Message field, it shows a dialog asking something like "Do you want to discard this Log Message ?" before closing the dialog. (If it is blank Escape will close the dialog unconditionally)
IIRC the log message is saved in the recent message list even if you
> In TortoiseCVS if you hit Escape and you have already entered anything in the Log Message field, it shows a dialog asking something like "Do you want to discard this Log Message ?" before closing the dialog. (If it is blank Escape will close the dialog unconditionally)
cancel the dialog.
Simon
------------------------------------------------------
http://tortoisesvn.tigris.org/ds/viewMessage.do?dsForumId=4061&dsMessageId=3091966
Jason Chown
Nov 28, 2014, 11:56:44 AM11/28/14
to us...@tortoisesvn.tigris.org
Ah! Sorry my initial description was wrong, as I usually lose my commit before I even realise what exactly I did, but I just recreated my problem.
You are right, escape does close dialogs, but there is a bug, I think.
The problem is the auto-complete: That's when I hit Escape, to dismiss the drop-down where it is offering me matching filenames. Escape cancels auto-complete in browsers/forms.
I think the correct behaviour is to close the auto-complete, and to only close the dialog if the text field isn't showing a drop-down.
------------------------------------------------------
http://tortoisesvn.tigris.org/ds/viewMessage.do?dsForumId=4061&dsMessageId=3091964
You are right, escape does close dialogs, but there is a bug, I think.
The problem is the auto-complete: That's when I hit Escape, to dismiss the drop-down where it is offering me matching filenames. Escape cancels auto-complete in browsers/forms.
I think the correct behaviour is to close the auto-complete, and to only close the dialog if the text field isn't showing a drop-down.
------------------------------------------------------
http://tortoisesvn.tigris.org/ds/viewMessage.do?dsForumId=4061&dsMessageId=3091964
Stefan Küng
Nov 28, 2014, 12:58:41 PM11/28/14
to us...@tortoisesvn.tigris.org
On 28.11.2014 17:11, Jason Chown wrote:
> Ah! Sorry my initial description was wrong, as I usually lose my
> commit before I even realise what exactly I did, but I just recreated
> my problem.
>
> You are right, escape does close dialogs, but there is a bug, I
> think.
>
> The problem is the auto-complete: That's when I hit Escape, to
> dismiss the drop-down where it is offering me matching filenames.
> Escape cancels auto-complete in browsers/forms.
>
> I think the correct behaviour is to close the auto-complete, and to
> only close the dialog if the text field isn't showing a drop-down.
You're absolutely right, that's a bug.
> Ah! Sorry my initial description was wrong, as I usually lose my
> commit before I even realise what exactly I did, but I just recreated
> my problem.
>
> You are right, escape does close dialogs, but there is a bug, I
> think.
>
> The problem is the auto-complete: That's when I hit Escape, to
> dismiss the drop-down where it is offering me matching filenames.
> Escape cancels auto-complete in browsers/forms.
>
> I think the correct behaviour is to close the auto-complete, and to
> only close the dialog if the text field isn't showing a drop-down.
Filed as issue #677:
https://code.google.com/p/tortoisesvn/issues/detail?id=677
Stefan
--
___
oo // \\ "De Chelonian Mobile"
(_,\/ \_/ \ TortoiseSVN
\ \_/_\_/> The coolest interface to (Sub)version control
/_/ \_\ http://tortoisesvn.net
------------------------------------------------------
David Balažic
Dec 1, 2014, 5:02:15 AM12/1/14
to us...@tortoisesvn.tigris.org
On 28. November 2014 16:53 Stefan Küng wrote:
> On 28.11.2014 16:47, Jason Chown wrote:
> ...
> On 28.11.2014 16:47, Jason Chown wrote:
> Second: While you want the escape key to NOT close the dialog, others
> want the escape key to close any TSVN dialog immediately without any
> confirmation or anything else even if it would mean getting corrupted
> working copies:
No they don't, they just want the dialog to disappear/close.
> want the escape key to close any TSVN dialog immediately without any
> confirmation or anything else even if it would mean getting corrupted
> working copies:
Let's not put words in each others mouths.
Regards,
David
------------------------------------------------------
http://tortoisesvn.tigris.org/ds/viewMessage.do?dsForumId=4061&dsMessageId=3092077
Jason Chown
Dec 1, 2014, 6:42:11 AM12/1/14
to us...@tortoisesvn.tigris.org
Thanks, Stefan!
------------------------------------------------------
http://tortoisesvn.tigris.org/ds/viewMessage.do?dsForumId=4061&dsMessageId=3092083
------------------------------------------------------
http://tortoisesvn.tigris.org/ds/viewMessage.do?dsForumId=4061&dsMessageId=3092083
Ryan Hathaway
Dec 1, 2014, 10:42:20 AM12/1/14
to torto...@gmail.com, us...@tortoisesvn.tigris.org
Glad it's going to be fixed properly, but as a workaround, you might be able to use change sets or the command-line interface to better enter overly-complicated partial commits so you don't have to start from scratch each time building a file list.
Thank you,
>>> Stefan Küng<torto...@gmail.com> 11/28/14 12:59 PM >>>
(I am fortunate, for most of my development work, I can usually just right-click/commit on the source project folder, and rarely have to uncheck more than a couple items before committing back to the trunk. In the commit dialog, I like to double-click each file to review diffs to double-check all the changes I'm about to submit and write a good log message with a short summarry of all the high-level changes which were applied to the codebase in that particular commit.)
Thank you,
-Ryan
Ryan Hathaway
Programmer Analyst
Office of Alan Harold, Auditor
Stark County Ohio
110 Central Plaza S
Canton, OH 44702
***Please note: My email address has changed to rghat...@starkcountyohio.gov ***
>>> Stefan Küng<torto...@gmail.com> 11/28/14 12:59 PM >>>
Reply all
Reply to author
Forward
0 new messages