blank window when no defect number and bugtraq:warnifnoissue=true
chr...@comcast.net
I have just installed the "latest" (TortoiseSVN 1.6.7, Build 18655 - 32 Bit -dev, 2010/02/19 19:39:53).
I have several bugtraq: properties set:
bugtraq:label Defect(s)
bugtraq:message Defect#: %BUGID%
bugtraq:url (my url)
bugtraq:warnifnoissue=true
When I commit without entering a defect number, I get a blank dialog (no text, no button, just a warning sign and the title "TortoiseSVN") instead of the warning about forgetting to enter a defect number. The dialog is not very high,
but it takes the entire screen width. If I hit enter, I can commit, if I hit tab then enter, it cancels.
This worked fine with the previous "latest" build.
Is this a defect, or is there a setting messed up on my system?
Thanks
Christophe
------------------------------------------------------
http://tortoisesvn.tigris.org/ds/viewMessage.do?dsForumId=4061&dsMessageId=2450561
To unsubscribe from this discussion, e-mail: [users-un...@tortoisesvn.tigris.org].
Stefan Küng
> Hi,
> I have just installed the "latest" (TortoiseSVN 1.6.7, Build 18655 - 32 Bit -dev, 2010/02/19 19:39:53).
> I have several bugtraq: properties set:
> bugtraq:label Defect(s)
> bugtraq:message Defect#: %BUGID%
> bugtraq:url (my url)
> bugtraq:warnifnoissue=true
>
>
> When I commit without entering a defect number, I get a blank dialog (no text, no button, just a warning sign and the title "TortoiseSVN") instead of the warning about forgetting to enter a defect number. The dialog is not very high,
> but it takes the entire screen width. If I hit enter, I can commit, if I hit tab then enter, it cancels.
>
> This worked fine with the previous "latest" build.
>
> Is this a defect, or is there a setting messed up on my system?
Do you have a language pack installed?
I checked the code and I can't see why this would happen.
Stefan
--
___
oo // \\ "De Chelonian Mobile"
(_,\/ \_/ \ TortoiseSVN
\ \_/_\_/> The coolest Interface to (Sub)Version Control
/_/ \_\ http://tortoisesvn.net
------------------------------------------------------
http://tortoisesvn.tigris.org/ds/viewMessage.do?dsForumId=4061&dsMessageId=2450583
chr...@comcast.net
I do occasionally use 2 monitors (laptop + main display). Also, I did try at some point to re-size the commit window by middle clicking/right clicking on the windows maximize box.
Is the size of the warning dialog stored somewhere (in the registry?). It is not re sizable when it shows up.
----- "Stefan Küng" <torto...@gmail.com> wrote:
> Do you have a language pack installed?
> I checked the code and I can't see why this would happen.
>
> Stefan
>
>
------------------------------------------------------
http://tortoisesvn.tigris.org/ds/viewMessage.do?dsForumId=4061&dsMessageId=2450603
Stefan Küng
> No language pack installed: I only installed one file "TortoiseSVN-1.6.7.18655-dev-win32-svn-1.6.9.msi"
>
> I do occasionally use 2 monitors (laptop + main display). Also, I did try at some point to re-size the commit window by middle clicking/right clicking on the windows maximize box.
>
> Is the size of the warning dialog stored somewhere (in the registry?). It is not re sizable when it shows up.
No, that message box doesn't save the last position at all.
I've started another 1.6.x build. Can you try in about three hours?
Stefan
--
___
oo // \\ "De Chelonian Mobile"
(_,\/ \_/ \ TortoiseSVN
\ \_/_\_/> The coolest Interface to (Sub)Version Control
/_/ \_\ http://tortoisesvn.net
------------------------------------------------------
http://tortoisesvn.tigris.org/ds/viewMessage.do?dsForumId=4061&dsMessageId=2450638
chr...@comcast.net
> I've started another 1.6.x build. Can you try in about three hours?
>
> Stefan
>
I will try later today or more likely tomorrow, getting the file at http://nightlybuilds.tortoisesvn.net/1.6.x/win32/
(sorry, I keep saying "latest" in my previous posts, but I really mean the 1.6. area - I usually do not download from /latest/).
Thanks in advance
Christophe
------------------------------------------------------
http://tortoisesvn.tigris.org/ds/viewMessage.do?dsForumId=4061&dsMessageId=2450651
chr...@comcast.net
> (sorry, I keep saying "latest" in my previous posts, but I really mean the 1.6. area - I usually do not download from /latest/).
I still get the empty dialog.
I installed TortoiseSVN 1.6.7, Build 18701 - 32 Bit -dev, 2010/02/22 22:18:49, rebooted and tried to commit without entering an issue number.
Christophe
------------------------------------------------------
http://tortoisesvn.tigris.org/ds/viewMessage.do?dsForumId=4061&dsMessageId=2450725
Stefan Küng
>> I will try later today or more likely tomorrow, getting the file at
>> http://nightlybuilds.tortoisesvn.net/1.6.x/win32/ (sorry, I keep
>> saying "latest" in my previous posts, but I really mean the 1.6.
>> area - I usually do not download from /latest/).
>
> I still get the empty dialog. I installed TortoiseSVN 1.6.7, Build
> 18701 - 32 Bit -dev, 2010/02/22 22:18:49, rebooted and tried to
> commit without entering an issue number.
Just tried it on my machine, works fine.
See attached screenshot.
Stefan
--
___
oo // \\ "De Chelonian Mobile"
(_,\/ \_/ \ TortoiseSVN
\ \_/_\_/> The coolest Interface to (Sub)Version Control
/_/ \_\ http://tortoisesvn.net
------------------------------------------------------
http://tortoisesvn.tigris.org/ds/viewMessage.do?dsForumId=4061&dsMessageId=2451112
chr...@comcast.net
> See attached screenshot.
I see. It is still not working here though, and seems to be only in the last couple of builds.
See my screen capture: I only had one monitor on (external monitor, laptop monitor was closed). I blanked some information, but I did not change the size of the dialogs. The warning dialog spans exactly the entire screen width (I moved it to make sure there was nothing passed the screen).
This is what I tried (reboot in between install/remove)
* I removed "TortoiseSVN 1.6.7, Build 18701 - 32 Bit -dev, 2010/02/22 22:18:49"
* I installed my previous version (TortoiseSVN-1.6.7.18415-win32-svn-1.6.9.msi
the dialog showed just fine. I even tried to maximize horizontally, then vertically: it all worked fine (warning dialog shows perfectly)
* I upgraded to TortoiseSVN-1.6.7.18701-dev-win32-svn-1.6.9.msi
the first thing I tried was to commit, and warning dialog is messed up.
Christophe
------------------------------------------------------
http://tortoisesvn.tigris.org/ds/viewMessage.do?dsForumId=4061&dsMessageId=2451135
Stefan Küng
>> Just tried it on my machine, works fine.
>> See attached screenshot.
>
> I see. It is still not working here though, and seems to be only in the last couple of builds.
>
> See my screen capture: I only had one monitor on (external monitor, laptop monitor was closed). I blanked some information, but I did not change the size of the dialogs. The warning dialog spans exactly the entire screen width (I moved it to make sure there was nothing passed the screen).
>
> This is what I tried (reboot in between install/remove)
>
> * I removed "TortoiseSVN 1.6.7, Build 18701 - 32 Bit -dev, 2010/02/22 22:18:49"
>
> * I installed my previous version (TortoiseSVN-1.6.7.18415-win32-svn-1.6.9.msi
> the dialog showed just fine. I even tried to maximize horizontally, then vertically: it all worked fine (warning dialog shows perfectly)
>
> * I upgraded to TortoiseSVN-1.6.7.18701-dev-win32-svn-1.6.9.msi
> the first thing I tried was to commit, and warning dialog is messed up.
Make sure you don't have any dlls in the Languages folder in the install
path of TSVN. It might be an old language dll that's causing this.
Stefan
--
___
oo // \\ "De Chelonian Mobile"
(_,\/ \_/ \ TortoiseSVN
\ \_/_\_/> The coolest Interface to (Sub)Version Control
/_/ \_\ http://tortoisesvn.net
------------------------------------------------------
http://tortoisesvn.tigris.org/ds/viewMessage.do?dsForumId=4061&dsMessageId=2451138
chr...@comcast.net
> Make sure you don't have any dlls in the Languages folder in the
> install
>
> path of TSVN. It might be an old language dll that's causing this.
>
All I can see in C:\Program Files\TortoiseSVN\Languages are those 2 files:
en_US.aff
en-US.dic
I believe I have always installed only in the default folder, and only installed the main msi (never installed extra language pack).
I will try to uninstall the current version and reinstall (instead of upgrading).
Christophe
------------------------------------------------------
http://tortoisesvn.tigris.org/ds/viewMessage.do?dsForumId=4061&dsMessageId=2451172
chr...@comcast.net
> I will try to uninstall the current version and reinstall (instead of upgrading).
Just tried it, and clean install does NOT fix the issue with build 18701. Again, clean install of previous version works (18415). I have not tried any other dialogs.
Christophe
------------------------------------------------------
http://tortoisesvn.tigris.org/ds/viewMessage.do?dsForumId=4061&dsMessageId=2451667
Stefan Küng
>> I believe I have always installed only in the default folder, and only installed the main msi (never installed extra language pack).
>> I will try to uninstall the current version and reinstall (instead of upgrading).
>
> Just tried it, and clean install does NOT fix the issue with build 18701. Again, clean install of previous version works (18415). I have not tried any other dialogs.
Can anyone else reproduce this?
I've tried now on Win7 and XP and can't reproduce it.
Stefan
--
___
oo // \\ "De Chelonian Mobile"
(_,\/ \_/ \ TortoiseSVN
\ \_/_\_/> The coolest Interface to (Sub)Version Control
/_/ \_\ http://tortoisesvn.net
------------------------------------------------------
http://tortoisesvn.tigris.org/ds/viewMessage.do?dsForumId=4061&dsMessageId=2452209
Robin Guest
Can anyone else reproduce this?
I've tried now on Win7 and XP and can't reproduce it.
Stefan
chr...@comcast.net
1) The OP has something installed that is mucking around with the window chrome - he has a push pin and arrow button on the commit window. Does he still get the problem if this software is temporarily uninstalled?
>
2) What characters get copied to the clipboard if the OP does Ctrl+C while the blank messagebox is displayed? In particular, is the window "full" of strange non-printing characters (and what are they), or is it entirely blank? Or, is it's message pump not working so that Ctrl+C doesn't even work?
I forgot about my pin button... (comes from FileBox eXtender 2.00.04) I turned it off (I don't think I need to uninstall - the pin goes away on all my windows) and now the warning dialog takes the entire screen (height and width) instead of just the screen width...and still no visible text in the dialog.
Ctrl-c gives me the expected text though:
You haven't entered an issue number!
Are you sure you want to commit without an issue number?
I also forgot to mention I am running XP Pro SP3.
Christophe
------------------------------------------------------
http://tortoisesvn.tigris.org/ds/viewMessage.do?dsForumId=4061&dsMessageId=2452216
Robin Guest
>I forgot about my pin button... (comes from FileBox eXtender 2.00.04) I turned it off (I don't think I need to uninstall - the pin goes away on all my windows) and now the warning dialog takes the entire screen (height and width) instead of just the screen width...and still no visible text in the dialog.
1) The OP has something installed that is mucking around with the window chrome - he has a push pin and arrow button on the commit window. Does he still get the problem if this software is temporarily uninstalled?
>
2) What characters get copied to the clipboard if the OP does Ctrl+C while the blank messagebox is displayed? In particular, is the window "full" of strange non-printing characters (and what are they), or is it entirely blank? Or, is it's message pump not working so that Ctrl+C doesn't even work?
Ctrl-c gives me the expected text though:
You haven't entered an issue number!
Are you sure you want to commit without an issue number?
I also forgot to mention I am running XP Pro SP3.
Christophe
chr...@comcast.net
That's good, it sounds like you are on the right track now, at least. If FileBox eXtender is capable of affecting the height of a standard dialog in weird ways when it's turned on, it's certainly capable of the rest of the behaviour you are seeing here.
>
I'm pretty sure utilities like FileBox eXtender usually hook windows API and do other low level trickery to achieve their effect. Just like is often said about virus checkers on this list, turning these things off is often not sufficient to disable them. This is likely to be becuse the hooking or filtering or service creation is an expensive operation, so they find it easier for a "turn off" to leave it enabled but return immediately when the functionality is called.
>
Try to temporarily uninstall then reboot, and see whether your entire problem goes away.
>
This doesn't mean that the Stefan will be able to fix it, or that there is anything to fix in TSVN at all. But at least you will have a reproduction recipe.
First, thanks for helping me out!
I uninstalled FileBox Extender and rebooted: the warning window still takes the entire screen.
After that, I tried to repair TSVN (running the installer again), then rebooted: issue still there.
To make sure, one more time, I removed build 18701, rebooted, re-installed 18415, rebooted: the issue is gone. I reinstalled FileBox Extender, and version 18415 still works just fine.
I don't know if we can do something about it, and I don't know what other dialogs maybe broken, but it sure looks like a recent code change is part of the issue (the other part may still be my system).
Christophe
------------------------------------------------------
http://tortoisesvn.tigris.org/ds/viewMessage.do?dsForumId=4061&dsMessageId=2452715
Stefan Küng
> I uninstalled FileBox Extender and rebooted: the warning window still
> takes the entire screen. After that, I tried to repair TSVN (running
> the installer again), then rebooted: issue still there. To make sure,
> one more time, I removed build 18701, rebooted, re-installed 18415,
> rebooted: the issue is gone. I reinstalled FileBox Extender, and
> version 18415 still works just fine.
>
> I don't know if we can do something about it, and I don't know what
> other dialogs maybe broken, but it sure looks like a recent code
> change is part of the issue (the other part may still be my system).
Well, you can check yourself if you like by doing a diff between the
1.6.7 tag and the 1.6.x branch:
there was no code change which could affect that dialog. Really: no code
change!
Stefan
--
___
oo // \\ "De Chelonian Mobile"
(_,\/ \_/ \ TortoiseSVN
\ \_/_\_/> The coolest Interface to (Sub)Version Control
/_/ \_\ http://tortoisesvn.net
------------------------------------------------------
http://tortoisesvn.tigris.org/ds/viewMessage.do?dsForumId=4061&dsMessageId=2452718
Christophe R.
> 1.6.7 tag and the 1.6.x branch:
> there was no code change which could affect that dialog. Really: no code
> change!
I trust you on that - I am not sure I would be looking at the right thing. I
did see something in the dev mailing list titled
"Possible bug: Inconsistent parent window for error messages in TortoiseProc
dialogs" - it probably is only for the nightly build, I just thougth it
might be related.
Anyway, tonight, I tried on a home machine that never had svn or TSVN
installed on. I put build 18701, and tried to create a repository on the
desktop: I get a giant (full screen) empty dialog. ctrl-c give me that text:
Subversion reported an error while creating a repository!
Make sure the folder is empty and not write protected.
That machine has XP Home, SP3, single monitor, and yes, it runs filebox
extender. I tried creating the repository with and without filebox extender,
(I uninstalled it and rebooted): in both cases I get the giant empty dialog.
Not sure what is common between those 2 dialogs (the "no defect entered" and
this "error while creating repository")...
Christophe
------------------------------------------------------
http://tortoisesvn.tigris.org/ds/viewMessage.do?dsForumId=4061&dsMessageId=2452799
Stefan Küng
>> Well, you can check yourself if you like by doing a diff between the
>> 1.6.7 tag and the 1.6.x branch:
>> there was no code change which could affect that dialog. Really: no code
>> change!
>
> I trust you on that - I am not sure I would be looking at the right thing. I
> did see something in the dev mailing list titled
> "Possible bug: Inconsistent parent window for error messages in TortoiseProc
> dialogs" - it probably is only for the nightly build, I just thougth it
> might be related.
That change wasn't merged back to 1.6.x.
> Anyway, tonight, I tried on a home machine that never had svn or TSVN
> installed on. I put build 18701, and tried to create a repository on the
> desktop: I get a giant (full screen) empty dialog. ctrl-c give me that text:
> Subversion reported an error while creating a repository!
> Make sure the folder is empty and not write protected.
>
> That machine has XP Home, SP3, single monitor, and yes, it runs filebox
> extender. I tried creating the repository with and without filebox extender,
> (I uninstalled it and rebooted): in both cases I get the giant empty dialog.
>
> Not sure what is common between those 2 dialogs (the "no defect entered" and
> this "error while creating repository")...
Can you try again please? I've uploaded another build, built with the
latest SDK since I've noticed that the nightly build server still had
the old SDK installed.
Stefan
--
___
oo // \\ "De Chelonian Mobile"
(_,\/ \_/ \ TortoiseSVN
\ \_/_\_/> The coolest Interface to (Sub)Version Control
/_/ \_\ http://tortoisesvn.net
------------------------------------------------------
http://tortoisesvn.tigris.org/ds/viewMessage.do?dsForumId=4061&dsMessageId=2453078
Christophe R.
> latest SDK since I've noticed that the nightly build server still had
> the old SDK installed.
That sounded promising, but at least on my home machine, it still does not
work: I created a repository on the desktop and I still get a full screen
blank dialog. Ctrl-C still gives me
"Subversion reported an error while creating a repository!
Make sure the folder is empty and not write protected."
To make sure I got the right version, this is what tsvn about box reports:
TortoiseSVN 1.6.7, Build 18765 - 32 Bit -dev, 2010/02/27 16:49:53
I am still surprised to be the only one running into that issue!
Christophe
------------------------------------------------------
http://tortoisesvn.tigris.org/ds/viewMessage.do?dsForumId=4061&dsMessageId=2453246
Christophe R.
> work: I created a repository on the desktop and I still get a full screen
> blank dialog. Ctrl-C still gives me
> "Subversion reported an error while creating a repository!
> Make sure the folder is empty and not write protected."
>
> To make sure I got the right version, this is what tsvn about box reports:
> TortoiseSVN 1.6.7, Build 18765 - 32 Bit -dev, 2010/02/27 16:49:53
>
> I am still surprised to be the only one running into that issue!
One more thing: still on my home machine, I went ahead an upgraded to
TortoiseSVN 1.6.99, Build 18769 - 32 Bit -dev, 2010/02/27 23:54:25 (from
http://nightlybuilds.tortoisesvn.net/latest/win32/full/)
Creating a repository on the desktop gives me a nice dialog - yes!
So the error seems to be only in the last few builds I got from
http://nightlybuilds.tortoisesvn.net/1.6.x/win32/
Christophe
------------------------------------------------------
http://tortoisesvn.tigris.org/ds/viewMessage.do?dsForumId=4061&dsMessageId=2453446
Stefan Küng
>> That sounded promising, but at least on my home machine, it still does not
>> work: I created a repository on the desktop and I still get a full screen
>> blank dialog. Ctrl-C still gives me
>> "Subversion reported an error while creating a repository!
>> Make sure the folder is empty and not write protected."
>>
>> To make sure I got the right version, this is what tsvn about box reports:
>> TortoiseSVN 1.6.7, Build 18765 - 32 Bit -dev, 2010/02/27 16:49:53
>>
>> I am still surprised to be the only one running into that issue!
>
>
>
> One more thing: still on my home machine, I went ahead an upgraded to
> TortoiseSVN 1.6.99, Build 18769 - 32 Bit -dev, 2010/02/27 23:54:25 (from
> http://nightlybuilds.tortoisesvn.net/latest/win32/full/)
> Creating a repository on the desktop gives me a nice dialog - yes!
> So the error seems to be only in the last few builds I got from
> http://nightlybuilds.tortoisesvn.net/1.6.x/win32/
I found a VM where I could reproduce the issue. Seems that
GetDeviceCaps() returns complete garbage.
I think I fixed the issue, a nightly build for the 1.6.x branch is
currently running. Should be up in about an hour.
Stefan
--
___
oo // \\ "De Chelonian Mobile"
(_,\/ \_/ \ TortoiseSVN
\ \_/_\_/> The coolest Interface to (Sub)Version Control
/_/ \_\ http://tortoisesvn.net
------------------------------------------------------
http://tortoisesvn.tigris.org/ds/viewMessage.do?dsForumId=4061&dsMessageId=2453604
chr...@comcast.net
> GetDeviceCaps() returns complete garbage.
>
> I think I fixed the issue, a nightly build for the 1.6.x branch is
> currently running. Should be up in about an hour.
>
Tada! That did it - the warning dialogs are now displaying just fine.
Thank you very much for looking into this and fixing the issue. Well, thanks a lot in general for TSVN :)
Christophe
------------------------------------------------------
http://tortoisesvn.tigris.org/ds/viewMessage.do?dsForumId=4061&dsMessageId=2453678
Stefan Küng
>> I found a VM where I could reproduce the issue. Seems that
>> GetDeviceCaps() returns complete garbage.
>>
>> I think I fixed the issue, a nightly build for the 1.6.x branch is
>> currently running. Should be up in about an hour.
>>
>
> Tada! That did it - the warning dialogs are now displaying just fine.
> Thank you very much for looking into this and fixing the issue. Well, thanks a lot in general for TSVN :)
> Christophe
Thanks for testing!
Stefan
--
___
oo // \\ "De Chelonian Mobile"
(_,\/ \_/ \ TortoiseSVN
\ \_/_\_/> The coolest Interface to (Sub)Version Control
/_/ \_\ http://tortoisesvn.net
------------------------------------------------------
http://tortoisesvn.tigris.org/ds/viewMessage.do?dsForumId=4061&dsMessageId=2454095