Bug: "Committing to tag" warning is not shown

[Dominik Gnthr]

Hi,

I recently stumbled upon a bug, when I found a user had committed to a tag.

Normally the function

CSVNProgressDlg::IsCommittingToTag checks if you're committing to a tag and warns you.

But if you include a file that is not inside a tag, then the warning isn't shown.

Example commit:

Changed /project/tags/test.txt

This shows the warning

Example commit with two files:

Changed /project/tags/test.txt

Changed /project/something.txt

This does not show the warning.

I'm using the newest version (TortoiseSVN 1.14.3, Build 29387 - 64 Bit) and have not found anything related to that in the documentation or the changelog.

It would be great if you could look into it.

Thank you and have a nice day, Dominik

[Stefan]

On Friday, August 5, 2022 at 4:14:17 PM UTC+2 Dominik Gnthr wrote:

Hi,

I recently stumbled upon a bug, when I found a user had committed to a tag.

Normally the function

CSVNProgressDlg::IsCommittingToTag checks if you're committing to a tag and warns you.

But if you include a file that is not inside a tag, then the warning isn't shown.

Example commit:

Changed /project/tags/test.txt

This shows the warning

Example commit with two files:

Changed /project/tags/test.txt

Changed /project/something.txt

This does not show the warning.

I assume here that you've chosen /project as the root of your commit. In that case of course the check won't catch that you might be committing to a tag. Because while you see the files in the commit dialog, when the actual commit happens only /project is passed, and no paths inside that folder.

But honestly: it's very, very unusual to have a working copy checked out from the repo root. I mean you would have *all* tags and branches checked out as well. That's a huge waste of disk space.

check out from /trunk of a branch instead, and use "switch" to change between your branches and trunk. That's the recommended way.

 

[Tony Rietwyk]

Stefan said "check out from /trunk of a branch instead..."

I assume that was meant to read "check out from /trunk OR a branch instead..."