TortoiseSVN can't fetch files with %ab symbols in path

[Ryurix]

Lastest version.

Create file in folder like \some-repository\%abc\

or file with name like \some-repository\%abc.php

make few changes and commits

right click -> Show log

i get message: 'some-repository/%ABc.php' path not found

looks like tortoise doesn't url encode symbol "%" when make http request, should be encoded %25

please help, i have many files with this problem

i think same error will happen with %00 -- %ff symbols in path, %str for example work fine

i think svn trying to decode %ab code to some symbol

[ryu...@gmail.com]

facepalm

среда, 12 февраля 2020 г., 12:52:44 UTC+3 пользователь Ryurix написал:

[Stefan]

works fine for me.

I can show the log for the file in the wc, from the commit dialog, from the repo browser, ...

works every time.

[pegacorn jp]

100% reproduction with TortoiseSVN 1.13.1.

/100%abc.txt        NG
/Hello/100%abc.txt  NG *1

*1 Reproduced after clearing the cache

[ryu...@gmail.com]

looks like your files been cached, try to make more commits

[dro...@gmail.com]

Can you describe in detailed steps to reporoduce this? What system Windows 7/10?

[ryu...@gmail.com]

Yes, Windows 10, lastest TortoiseSVN.

1. In any repository create file with name %ab.txt

2. Add

3. Commit

4. Make changes

5. Commit again

6. Right click on file -> Show log

7. You get message: '[path-to-repository]%AB.txt' path not found.

понедельник, 2 марта 2020 г., 1:28:44 UTC+3 пользователь (неизвестно) написал:

[ryu...@gmail.com]

Same thing will happens if you create file in folder with name with symbols like %ab or %4d

Problem that TortoiseSVN does not code percent character during http request.

for example, for file %4d.txt

TortoiseSVN trying to fetch [path]/%4d.txt

what means for Apache [path]/%M.txt (4D ascii code = M)

when should be: [path]/%254d.txt (25 hex ascii code = %)

понедельник, 2 марта 2020 г., 10:54:14 UTC+3 пользователь Ryurix написал:

[David Balažic]

I can reproduce this using a (newly created) local repo and the steps below.

TSVN ver 1.13.1 , Windows 10

The error in the "Log Messages" window is:

File not found: revision 3, path '/?c.txt'

The question mark is white inside a black diamond character (the usual "unknown code" symbol).

Regards,

David

[dro...@gmail.com]

It does repro for the local repo (`file:///`), no need for http request.

[Stefan]

I can reproduce it with "%ab.txt", but not with (what I tried before) "%test.txt".

And the strange thing is: the GetCommandLineW() API returns the string of the path already corrupted, i.e, it treats %ab as an escape sequence. But I can't find anything in the MS docs about this.

[dro...@gmail.com]

May be because GetCommandLine *already* returns a parsed string?

[ryu...@gmail.com]

Bug still there, just checked lastest night build. Is there any hope that it will be fixed?

среда, 12 февраля 2020 г., 12:52:44 UTC+3 пользователь Ryurix написал:

Lastest version.