Minor bug when deleting unversioned files

[Asa Packer]

Hello,

I noticed what seems to be a (minor) bug when I was cleaning up my working copy from the "SVN Check for Modifications" window.  This is with 1.14.9.29743 on Windows 11.  Here's how to repro:

Create an empty folder in your working copy and commit it so it is under version control.  Suppose the folder's name is "foo".  Inside foo, create these unversioned files/folders:

folder "bar"

folder "bar/blah"

file "bar.txt"

Now do "SVN Check for Modifications" on "foo".  You should see the three unversioned items.  Select all three of them, right-click, and choose "Delete".  I expected them to just be quietly recycled, but instead I get the recycle bin error window shown below.  If I click "Skip", then the "Check for Modifications" window still shows all three unversioned items, although they actually have been deleted.  If I click "Yes" instead, then the "Check for Modifications" window is empty as it should be.

Obviously there is an easy workaround - just click Yes in the error window - but the behavior is a little confusing.

I do have the "Recurse into unversioned folders" setting enabled in TortoiseSVN settings > Dialogs 2.

I noticed that the three unversioned items show up in the "Check for Modifications" window in the following order:

bar

bar.txt

bar/blah

I wonder if the fact that the subfolder "bar/blah" is not immediately after the parent folder "bar" is related?

I am happy to try to fix this myself but I have never worked on the TortoiseSVN code so I wouldn't have any idea where to start looking.

Thanks!

Asa

[Stefan]

fixed in r29750