Retry option for "Want to go offline?"

[David Balažic]

Hi!

I got a "Want to go offline?" dialog for "Show log" action.

After I fixed the network, I missed a "retry" option in that dialog.

Can it be added, please?

Regards,

David

PS: Using version 1.10.1

[Stefan]

On Thursday, September 6, 2018 at 3:38:01 PM UTC+2, David Balažic wrote:

Hi!

I got a "Want to go offline?" dialog for "Show log" action.

After I fixed the network, I missed a "retry" option in that dialog.

Can it be added, please?

That's an issue that's been there a long time:

RepositoryInfo.cpp, line 430ff:

        // TODO: improve the dialog with
        // * the error message (why do we think the repository is offline?)
        //   this could be shown in the dialog itself in a label, a separate popup
        //   from a "show error" button or simply a tooltip
        // * a button to retry
        //
        // for this, the IsOffline() method needs changing:
        // * requires a param for the error message (or the SVNError exception object)
        // * an int return type which tells either to cancel, go offline, retry, ...


Problem is: this is a lot of work. And since retrying manually isn't much work (i.e., show the log dialog again), I'm just not sure it's worth the effort.