Feature request: show the amount of data to be submitted on the commit window

33 views
Skip to first unread message

Adam Jones

unread,
Oct 31, 2021, 7:00:00 AM10/31/21
to TortoiseSVN
This is a tiny feature request.   Please add the amount of data to be transmitted for the commit to the bottom right of the commit window where the number of files is listed.   

Having a little info and transparency on the data transfer before it takes place would be really useful when on a slow connection / dealing with very large commits.


Screenshot 2021-10-31 073802.png

Stefan

unread,
Oct 31, 2021, 7:01:18 AM10/31/21
to TortoiseSVN
you can't just add up the file sizes to determine the data to be transferred. Because only changes are transferred, not whole files.

Adam Jones

unread,
Oct 31, 2021, 7:16:19 AM10/31/21
to TortoiseSVN on behalf of Stefan
Exactly and this is what I'm suggesting;  that this correct calculation is made by determining the total of each individual files change data.  That could be done on the local system before submission and shown in this box here.   It may be that the figure doesn't appear instantly as the window renders and that it has to calculate enumerating through files in the background once the window is up.  

On Sun, 31 Oct 2021 at 08:01, Stefan via TortoiseSVN <torto...@googlegroups.com> wrote:
you can't just add up the file sizes to determine the data to be transferred. Because only changes are transferred, not whole files.

--
You received this message because you are subscribed to a topic in the Google Groups "TortoiseSVN" group.
To unsubscribe from this topic, visit https://groups.google.com/d/topic/tortoisesvn/EGEkWK8icV4/unsubscribe.
To unsubscribe from this group and all its topics, send an email to tortoisesvn...@googlegroups.com.
To view this discussion on the web visit https://groups.google.com/d/msgid/tortoisesvn/e5e3cc73-96ad-4e67-9bcf-07e9cb8d2642n%40googlegroups.com.


--

Adam Jones
Web Developer 

Daniel Sahlberg

unread,
Nov 1, 2021, 4:33:16 AM11/1/21
to TortoiseSVN
söndag 31 oktober 2021 kl. 12:16:19 UTC+1 skrev Adam Jones:
Exactly and this is what I'm suggesting;  that this correct calculation is made by determining the total of each individual files change data.  That could be done on the local system before submission and shown in this box here.   It may be that the figure doesn't appear instantly as the window renders and that it has to calculate enumerating through files in the background once the window is up.  

I checked with some of the Subversion developers and it is not an easy thing to estimate or guess the size of a commit before it happens. To quote them you need to "deltify the files" and then sum up the changes (possibly adding overhead). Of course it can be done, but there are no APIs for this currently. Any changes should probably be done in the Subversion code first and then it it should be a relatively small change to call these APIs from TortoiseSVN. If you are interested to  help, please check https://subversion.apache.org/contributing.html.

Kind regards,
Daniel

Niemann, Hartmut

unread,
Nov 3, 2021, 4:15:00 AM11/3/21
to TortoiseSVN

How hard and how useful would it be to list the combined file size

303 files (37kBytes) selected, 305 files (219kBytes) total

(i.e. show the file size and leave the guessing how big the commit might be to the user)?

It would at least give a hint whether really large files are added/selected/committed,

like compiled binaries or big pictures.

(Some projects I work with store 200MBytes+ disk images in SVN and then you want to know in advance whether that file is checked or not ..)

 

Hartmut

--
You received this message because you are subscribed to the Google Groups "TortoiseSVN" group.
To unsubscribe from this group and stop receiving emails from it, send an email to tortoisesvn...@googlegroups.com.
To view this discussion on the web visit https://groups.google.com/d/msgid/tortoisesvn/e28c4ef0-d97c-443c-a930-58be86041917n%40googlegroups.com.

Daniel Sahlberg

unread,
Nov 3, 2021, 7:15:19 AM11/3/21
to TortoiseSVN
onsdag 3 november 2021 kl. 09:15:00 UTC+1 skrev H. Niemann:

How hard

Probably not very hard if it is to just sum up the sizes.
 

and how useful

 If useful = accurate: The answer will range from "not at all" to "quite accurate". It all depends on what type of files you have and what changes you have done.

A text file will deltify beautifully (I don't dare to give a guess but in the same order of magnitude as the changed bytes). A Word document where change a single line might require resending the whole file (since it is a ZIP file and small change might reset the whole compression scheme).

So for defining a worst-case scenario it might be useful.

Stefan

unread,
Nov 5, 2021, 11:23:36 AM11/5/21
to TortoiseSVN
On Wednesday, November 3, 2021 at 12:15:19 PM UTC+1 daniel.l...@gmail.com wrote:

So for defining a worst-case scenario it might be useful.


No, it won't be useful. Because users can't tell if the information is accurate or not. So what they see is most of the time (at least for users who deal mostly with code, and that's the majority) very, very inaccurate. And therefore useless.
Also don't forget: if such an info is shown, users will start to complain that it's inaccurate, and no FAQ/Help will help us because users don't read those and they'll come here to complain about it (several times, because they also don't search the list before posting), or just silently decide that TSVN is crap.

So no: I won't implement something like this.

Stefan

David Balažic

unread,
Nov 6, 2021, 6:16:38 AM11/6/21
to TortoiseSVN
There is a simple solution for that: mark/label the value appropriately

Like: approximate amount of data to transfer
Or: data amount estimate: up to x MB

They don't need to look in the FAQ if it is written right there.

Regards,
David

Stefan

unread,
Nov 6, 2021, 8:45:01 AM11/6/21
to TortoiseSVN
On Saturday, November 6, 2021 at 11:16:38 AM UTC+1 David Balažic wrote:
There is a simple solution for that: mark/label the value appropriately

Like: approximate amount of data to transfer
Or: data amount estimate: up to x MB


post subject: bug: approximation is useless
post subject: estimate is completely wrong, please fix
post subject: bug: transferred data completely wrong
...

Even if you say it's "up to" or an "approximation", it won't help.

Just search the internet about the progress bar when copying files in the explorer, or the progress bar when installing windows updates, or ...


Daniel Sahlberg

unread,
Nov 7, 2021, 8:30:45 AM11/7/21
to TortoiseSVN
I agree with the assessment that labeling this feature as "estimate of data transfer" will be a cause of all kinds of bug reports "your estimate is wrong". Even if Subversion offered a way to deltify the files in advance to give a reasonable estimate of the transfer size, YMMV because of different thing: network overhead, on-the-wire compression to mention a few.

Would it make a difference to just label it as a "sum of selected file size" and never mentioning transfer size?

Kind regards,
Daniel


Reply all
Reply to author
Forward
0 new messages