Discussion on 1.9.2 Bugfix "Show unified diff" in the log dialog did not include the last (lowest) revision

[Christian Hein]

Hi there,

like mentioned above in Version 1.9.2 there was a "bug fix" concerning the "Show unified diff" dialog, which didn't include the so called lowest revision. Yes, it's been a long time since then. Due to some issues we now want to update our tortoise-svn-clients from 1.8.7 when we first startet using svn to a newer version.

We are very busy in creating and using unified diffs for certain files in our development process. Switching to a newer client version (1.9.2 and above) we discovered, that our reports wich we created on base of the unified diff in our usual way (marking to revisions of the file in the Show-dialog and selecting "show diffences as unified diff" did not conain the expected results any more.

Due to some investigations, we found out, that this behaivour changed with version 1.9.2

In my opinon the expected behaviour when creating a diff from two selected revisions A and B (where B is newer than A) is,  that  i see all changes made between revision A and B not including the changes which led to A. Like i checkout the file in both revisions an perform a diff manually.

So could you by chance explain the points leading to this change. Or maybe i don't understand the philosophy behind it.

Sincerely Christian

[Daniel Sahlberg]

fredag 2 juni 2023 kl. 10:54:49 UTC+2 skrev christia...@gmail.com:

So could you by chance explain the points leading to this change. Or maybe i don't understand the philosophy behind it.

I think Stefan has previously explained (but I can't find the actual thread) that it more consistent with general Windows user experience to include the changes in all the selected revisions rather than "in all revisions except the lowest".

Remember that you can select non-consecutive revisions in the log window (using Ctrl-click), then you get the changes from the selected revisions.

It would make a non-consistent UX if a consecutive range would not include all selected revisions.

This is different from the svn command line client where "svn diff -r29575:29576" only show changes from 29576.

The behaviour of TortoiseSVN is rather comparable with "svn diff -c29576 -c29575" (ignoring the fact that the command line client does not accept multiple -c arguments).

Kind regards,

Daniel Sahlberg