Should not encode undecoded URLs

[hiruka...@gmail.com]

Should not encode undecoded URLs

TortoiseSVN is great.
TortoiseSVN recognizes the HTML repository list returned by SVNListParentPath.
However, there is a problem with HTML processing.

Apache httpd.conf

<Location />
DAV svn
SVNParentPath "C:/svn"
SVNListParentPath on
</Location>

I used multi-byte characters including Japanese for the repository.
C:\>svnadmin create テスト

WebDAV URL: http://localhost/テスト/
List URL(Not WebDAV): http://localhost/

TortoiseSVN -> Repo-browser
URL: http://localhost/

List URL(Not WebDAV) http://localhost/ returns HTML containing the encoded URL.

<li><a href="%e3%83%86%e3%82%b9%e3%83%88/">テスト/</a></li>

TortoiseSVN shows tree view (URL not decoded)
http://localhost
- %e3%83%86%e3%82%b9%e3%83%88

Click %e3%83%86%e3%82%b9%e3%83%88 in the tree view.

> Unable to connect to a repository at URL
> 'http://localhost/%25e3%2583%2586%25e3%2582%25b9%25e3%2583%2588'
> Could not find the requested SVN filesystem

Why do you encode the URL?
Should not encode undecoded URLs.

<li><a href="%e3%83%86%e3%82%b9%e3%83%88/">テスト/</a></li>

The href value should not be encoded.
And the screen should display anchor text instead of href.

[Stefan]

Thanks for the detailed report.

Fixed in r28585.

[比留川亮]

Thank you very much.

I have confirmed that errors do not occur in nightly builds.

However, the tree view will still show escaped values.

It would be better if the URL decoded value is displayed.

Could you also correct the display?

[Stefan]

done in r28588.

Stefan

[比留川亮]

Thank you for your perfect work!

The problem was solved with the following version.

TortoiseSVN-1.12.0.28589-dev-x64-ipv6-svn-1.12.0.msi

2019年6月16日日曜日 22時23分29秒 UTC+9 Stefan:

done in r28588.

Stefan