Updated dependencies for TortoiseSVN

[Daniel Sahlberg]

Hi,

I've spent the weekend updating several dependencies for TortoiseSVN:

- APR: 1.7.2 to 1.7.3

- OpenSSL: 1.1.1t to 3.1.0 (the 1.1 series is EOL on 11th September 2023).

- Serf: 1.3.9 to current trunk version (needed for OpenSSL 3 compatibility, I'm hoping for a new release of Serf before the next Subversion/TSVN release, otherwise there is a simple patch we can apply in the build process).

- Zlib: 1.2.11 to 1.2.13.

Nightly builds should be available from tomorrow (the nightly builds today failed because of a missing buildstep).

The update to OpenSSL 3 should solve a problem with building the ARM version (unfortunately there is no nightly build for ARM).

Please feel free to test!

Kind regards,

Daniel Sahlberg

[Stefan]

Not sure if it has something to do with this, but now I get an SVN_ERR_FS_INDEX_OVERFLOW error on ever commit to a file:/// repository.

Can't be the updated OpenSSL or serf, but maybe the APR one?

 .\svn.exe commit D:\Development\SVN\Tests\repospacewc --message="test"       ⏱️0ms
Sending        Tests\repospacewc\src\AboutDlg.cpp
Transmitting file data .done
Committing transaction...
D:\Development\SVN\TortoiseSVN\ext\subversion\subversion\svn\commit-cmd.c:185,
D:\Development\SVN\TortoiseSVN\ext\subversion\subversion\libsvn_client\commit.c:1097,
D:\Development\SVN\TortoiseSVN\ext\subversion\subversion\libsvn_client\commit.c:156: (apr_err=SVN_ERR_FS_INDEX_OVERFLOW)svn: E160056: Commit failed (details follow):
D:\Development\SVN\TortoiseSVN\ext\subversion\subversion\libsvn_client\commit.c:1003,
D:\Development\SVN\TortoiseSVN\ext\subversion\subversion\libsvn_client\commit_util.c:1974,
D:\Development\SVN\TortoiseSVN\ext\subversion\subversion\libsvn_repos\commit.c:867,
D:\Development\SVN\TortoiseSVN\ext\subversion\subversion\libsvn_fs\fs-loader.c:885,
D:\Development\SVN\TortoiseSVN\ext\subversion\subversion\libsvn_fs_fs\tree.c:2381,
D:\Development\SVN\TortoiseSVN\ext\subversion\subversion\libsvn_fs_fs\transaction.c:3983,
D:\Development\SVN\TortoiseSVN\ext\subversion\subversion\libsvn_fs_fs\fs_fs.c:368,
D:\Development\SVN\TortoiseSVN\ext\subversion\subversion\libsvn_fs_fs\fs_fs.c:240,
D:\Development\SVN\TortoiseSVN\ext\subversion\subversion\libsvn_fs_fs\fs_fs.c:228,
D:\Development\SVN\TortoiseSVN\ext\subversion\subversion\libsvn_fs_fs\transaction.c:3912,
D:\Development\SVN\TortoiseSVN\ext\subversion\subversion\libsvn_fs_fs\transaction.c:3489,
D:\Development\SVN\TortoiseSVN\ext\subversion\subversion\libsvn_fs_fs\tree.c:4864,
D:\Development\SVN\TortoiseSVN\ext\subversion\subversion\libsvn_fs_fs\tree.c:4729,
D:\Development\SVN\TortoiseSVN\ext\subversion\subversion\libsvn_fs_fs\dag.c:275,
D:\Development\SVN\TortoiseSVN\ext\subversion\subversion\libsvn_fs_fs\dag.c:167,
D:\Development\SVN\TortoiseSVN\ext\subversion\subversion\libsvn_fs_fs\cached_data.c:533,
D:\Development\SVN\TortoiseSVN\ext\subversion\subversion\libsvn_fs_fs\cached_data.c:471,
D:\Development\SVN\TortoiseSVN\ext\subversion\subversion\libsvn_fs_fs\cached_data.c:228,
D:\Development\SVN\TortoiseSVN\ext\subversion\subversion\libsvn_fs_fs\index.c:1799,
D:\Development\SVN\TortoiseSVN\ext\subversion\subversion\libsvn_fs_fs\index.c:1587,
D:\Development\SVN\TortoiseSVN\ext\subversion\subversion\libsvn_fs_fs\index.c:1491: (apr_err=SVN_ERR_FS_INDEX_OVERFLOW)
svn: E160056: Item index 2 too large in revision 4

[Stefan]

yep, it's the new apr version.

I'll go back to apr 1.7.2 - this needs to be fixed either in apr or the svn lib.

[Daniel Sahlberg]

tisdag 11 april 2023 kl. 19:33:37 UTC+2 skrev Stefan:

yep, it's the new apr version.

I'll go back to apr 1.7.2 - this needs to be fixed either in apr or the svn lib.

Doh. That is rather stupid. I'm sending this upstream, first to the Subversion project but I have a feeling it is a problem in APR.

+1 on reverting to 1.7.2.

Kind regards,

Daniel 

[Daniel Sahlberg]

There was a quick response on the Subversion dev mailing list [1] and a fix has already been committed in the APR tree. It should be possible to switch to https://svn.apache.org/repos/asf/apr/apr/branches/1.7.x for verification.

Kind regards,

Daniel

[1] https://lists.apache.org/thread/56gnyc3tc0orjh5mfsqo9gpq1br59b01

 

[Daniel Sahlberg]

onsdag 12 april 2023 kl. 16:59:15 UTC+2 skrev Daniel Sahlberg:

tisdag 11 april 2023 kl. 22:47:54 UTC+2 skrev Daniel Sahlberg:

tisdag 11 april 2023 kl. 19:33:37 UTC+2 skrev Stefan:

yep, it's the new apr version.

I'll go back to apr 1.7.2 - this needs to be fixed either in apr or the svn lib.

Doh. That is rather stupid. I'm sending this upstream, first to the Subversion project but I have a feeling it is a problem in APR.

+1 on reverting to 1.7.2.

There was a quick response on the Subversion dev mailing list [1] and a fix has already been committed in the APR tree. It should be possible to switch to https://svn.apache.org/repos/asf/apr/apr/branches/1.7.x for verification.

APR will shortly release 1.7.4 with the above fix as the only change. The 1.7.4 tag already exists and it builds fine and the error is gone.

Any objections to switch to 1.7.4?

Kind regards,

Daniel

[Stefan]

Any objections to switch to 1.7.4?

no objections at all!

Stefan 

[Evgeny Kotkov]

Daniel Sahlberg writes:

> - Serf: 1.3.9 to current trunk version (needed for OpenSSL 3 compatibility,
> I'm hoping for a new release of Serf before the next Subversion/TSVN
> release, otherwise there is a simple patch we can apply in the build
> process).

With the recent backports on the branch, serf 1.3.x should work fine with
OpenSSL 3. There is no release yet, but perhaps it would be nice to switch
TSVN externals to the current state of the serf 1.3.x branch, to ensure that
everything works as expected.


Thanks,
Evgeny Kotkov

[Daniel Sahlberg]

Evgeny,

Since  r29562 (nightly builds 2023-05-21 and later) TortoiseSVN should be using the 1.3.x branch. Builds seems fine, I've been using them for a few days. Please be aware of a regression in the LogCache, hopefully fixed in r29564 (nightly builds 2023-05-25 and later).

Kind regards,

Daniel

[1] https://groups.google.com/g/tortoisesvn-dev/c/lTyZdQwpvGo

[Evgeny Kotkov]

Daniel Sahlberg <tortois...@googlegroups.com> writes:

> Evgeny,
>
> Since r29562 (nightly builds 2023-05-21 and later) TortoiseSVN should be
> using the 1.3.x branch. Builds seems fine, I've been using them for a
> few days.

Serf 1.3.10 with support for OpenSSL 3 has been officially released [1], so
I'm guessing that TortoiseSVN can now be switched to the official version.

(And thanks for giving the pre-release version a spin, it was useful to know
that there are no problems related to serf/OpenSSL 3.)

[1] https://lists.apache.org/thread/59sfvyv1c8oovxt73pb86foc7jgrcl25


Thanks,
Evgeny Kotkov

[Daniel Sahlberg]

Thank you Evgeny for pushing the Serf 1.3.10 release!

I've changed the svn:external to point to the 1.3.10 tag in r29571. I will check the nightly builds tomorrow and switch to it on my dev machine.

Kind regards,

Daniel