Autocompletion in the CInputLogDlg

[Daniel Sahlberg]

Based on the question in the users group about the name of the [deleted] file as a suggestion in the log message ([1]) , I have created a branch /branches/autocomplete_in_repobrowser_logdlg

Please check if this is reasonable / functional and if it should be merged to trunk. From my point of view it is feature complete but it might benefit from some code cleanup and possibly refactoring some of the duplicated code from CCommitDlg.

Kind regards,

Daniel

[1] https://groups.google.com/g/tortoisesvn/c/m1VpvqoSQTI

[Stefan]

looks good to me.

I made two small changes on your branch. If you're ok with that then please merge it back to trunk.

Stefan

[Daniel Sahlberg]

måndag 6 juni 2022 kl. 07:12:07 UTC+2 skrev Stefan:

looks good to me.

I made two small changes on your branch. If you're ok with that then please merge it back to trunk.

+1 on the refactoring. This is what I wanted to do as well but I didn't really know where to place the function.

-1 on reusing GetAppDirectory() via the appDir variable. GetAppDirectory() != GetAppDataDirectory(). (Otherwise no point in calling ParseSnippetFile twice). I have reverted this part of r29410.

L/_T. +0 (C++ is not my primary language, learning it is part of my motivation to contribute to TSVN) but I suppose TSVN is always compiled in Unicode so it doesn't matter.

+1 on const auto &.

I have changed CCommitDlg::GetAutocompletionList to include the last two changes as well.

Kind regards,

Daniel

[Stefan]

+1

please merge

[Daniel Sahlberg]

tisdag 7 juni 2022 kl. 17:34:23 UTC+2 skrev Stefan:

+1

please merge

I added a Changelog entry to the branch (r29413).

Then merged everything to trunk (r29414) excluding the BRANCH-README.

What is the policy for deleting feature branches? I can see that the shelve and tortoisemerge-native-ribbon branches were handled differently, where the first one still exists (although it was completely merged to trunk) and the second one deleted. Personally I believe there is little use in keeping the feature branches after merge to trunk, it is always possible to go back in time to check the logs if needed.

/Daniel

[Stefan]

haven't even realized that there are still such old branches lying around.

I've removed them now.

Stefan